> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Jani > Nikula > Sent: Monday, June 19, 2023 1:46 AM > To: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane@xxxxxxxxx>; intel- > gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane@xxxxxxxxx> > Subject: Re: [PATCH 04/11] drm/i915/JSL: s/JSL/JASPERLAKE for > platform/subplatform defines > > On Thu, 15 Jun 2023, Dnyaneshwar Bhadane > <dnyaneshwar.bhadane@xxxxxxxxx> wrote: > > Follow consistent naming convention. Replace JSL with JASPERLAKE. > > > > Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@xxxxxxxxx> > > > -#define IS_JSL_EHL(i915) (IS_PLATFORM(i915, INTEL_JASPERLAKE) || \ > > +#define IS_JASPERLAKE_EHL(i915) (IS_PLATFORM(i915, > INTEL_JASPERLAKE) || \ > > IS_PLATFORM(i915, INTEL_ELKHARTLAKE)) > > The new name for this is just dumb. This matches two platforms, JSL and EHL, > and there's no point in one of them being an acronym and the other one not. > > And IS_JASPERLAKE_ELKHARTLAKE() would be too long. > Agreed on the long name. Given that we are not touching Elkhartlake in this series, we can probably skip jasperlake too? Anusha > BR, > Jani. > > -- > Jani Nikula, Intel Open Source Graphics Center
