On Fri, 2023-05-26 at 19:37 +0300, Jani Nikula wrote: > Bring back -Wunused-but-set-variable both in W=1 build as well as > locally for CI and development. This already found dubious code. for the whole set (including v2 of patch 01) : Reviewed-by: Jouni Högander <jouni.hogander@xxxxxxxxx> > > Jani Nikula (15): > drm/i915/plane: warn on non-zero plane offset > drm/i915/ddi: drop unused but set variable intel_dp > drm/i915/dsi: drop unused but set variable data > drm/i915/dsi: drop unused but set variable vbp > drm/i915/dpll: drop unused but set variables bestn and bestm1 > drm/i915/fb: drop unused but set variable cpp > drm/i915/irq: drop unused but set variable tmp > drm/i915/gt/uc: drop unused but set variable sseu > drm/i915/gem: drop unused but set variable unpinned > drm/i915/gem: annotate maybe unused but set variable c > drm/i915/selftest: annotate maybe unused but set variable unused > drm/i915: annotate maybe unused but set intel_plane_state variables > drm/i915: annotate maybe unused but set intel_crtc_state variables > drm/i915/gvt: annotate maybe unused gma_bottom variables > drm/i915: re-enable -Wunused-but-set-variable > > drivers/gpu/drm/i915/Makefile | 2 +- > drivers/gpu/drm/i915/display/i9xx_plane.c | 2 ++ > drivers/gpu/drm/i915/display/intel_atomic_plane.c | 2 +- > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- > drivers/gpu/drm/i915/display/intel_ddi.c | 4 ---- > drivers/gpu/drm/i915/display/intel_display.c | 10 +++++----- > drivers/gpu/drm/i915/display/intel_display_irq.c | 4 ++-- > drivers/gpu/drm/i915/display/intel_dpll.c | 4 +--- > drivers/gpu/drm/i915/display/intel_fb.c | 3 +-- > drivers/gpu/drm/i915/display/intel_fbc.c | 6 +++--- > drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 + > drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- > drivers/gpu/drm/i915/display/vlv_dsi.c | 6 ++---- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 +-- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- > drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 2 -- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 ++-- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- > 18 files changed, 26 insertions(+), 35 deletions(-) >
