== Series Details == Series: drm/i915: GSC FW support for MTL (rev3) URL : https://patchwork.freedesktop.org/series/117396/ State : warning == Summary == Error: dim checkpatch failed b8b9ea4aab9a drm/i915/gsc: fixes and updates for GSC memory allocation a3b0ea9a67d7 drm/i915/mtl/gsc: extract release and security versions from the gsc binary -:83: CHECK:LINE_SPACING: Please don't use multiple blank lines #83: FILE: drivers/gpu/drm/i915/gt/uc/intel_gsc_binary_headers.h:64: + + -:92: ERROR:SPACING: space required after that ',' (ctx:VxV) #92: FILE: drivers/gpu/drm/i915/gt/uc/intel_gsc_binary_headers.h:73: +#define INTEL_GSC_BPDT_ENTRY_TYPE_MASK GENMASK(15,0) ^ -:282: CHECK:LINE_SPACING: Please don't use multiple blank lines #282: FILE: drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c:196: + + total: 1 errors, 0 warnings, 2 checks, 395 lines checked bcc84b63080f drm/i915/mtl/gsc: query the GSC FW for its compatibility version -:104: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #104: FILE: drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c:370: + gt_err(gt, "invalid GSC reply length %u [expected %zu], s=0x%x, f=0x%x, r=0x%x\n", + msg_out->header.message_size, sizeof(*msg_out), total: 0 errors, 0 warnings, 1 checks, 193 lines checked 2d081dbad641 drm/i915/mtl/gsc: Add a gsc_info debugfs Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:147: CHECK:LINE_SPACING: Please don't use multiple blank lines #147: FILE: drivers/gpu/drm/i915/gt/uc/intel_gsc_uc.c:330: + + -:189: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #189: new file mode 100644 -:317: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'base' - possible side-effects? #317: FILE: drivers/gpu/drm/i915/i915_reg.h:961: +#define HECI_FWSTS(base, x) _MMIO((base) + _PICK(x, -(base), \ + HECI_FWSTS1, \ + HECI_FWSTS2, \ + HECI_FWSTS3, \ + HECI_FWSTS4, \ + HECI_FWSTS5, \ + HECI_FWSTS6)) total: 0 errors, 1 warnings, 2 checks, 250 lines checked 0d75b5b4975a drm/i915/gsc: define gsc fw -:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'major_' - possible side-effects? #66: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:242: +#define GSC_FW_BLOB(prefix_, major_, minor_) \ + UC_FW_BLOB_NEW(major_, minor_, 0, true, \ + MAKE_GSC_FW_PATH(prefix_, major_, minor_)) -:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'minor_' - possible side-effects? #66: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:242: +#define GSC_FW_BLOB(prefix_, major_, minor_) \ + UC_FW_BLOB_NEW(major_, minor_, 0, true, \ + MAKE_GSC_FW_PATH(prefix_, major_, minor_)) total: 0 errors, 0 warnings, 2 checks, 71 lines checked
