Re: [PATCH] drm/i915: fix gen4 digital port hotplug definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi list,

Am 26.07.2013 21:46, schrieb Daniel Vetter:
On Fri, Jul 26, 2013 at 07:54:22PM +0200, Daniel Vetter wrote:
On Fri, Jul 26, 2013 at 01:21:48PM +0300, Jani Nikula wrote:
> On Fri, 26 Jul 2013, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> > Apparently Bspec is wrong in this case here even for gm45. Note that > > Bspec is horribly misguided on i965g/gm, so we don't have any other
> > data points besides that it seems to make machines work better.
> >
> > With this changes all the bits in PORT_HOTPLUG_STAT for the digital > > ports are ordered the same way. This seems to agree with what register > > dumps from the hpd storm handling code shows, where the LIVE bit and > > the short/long pulse STATUS bits light up at the same time with this
> > enumeration (but no with the one from Bspec).
>
> Would a comment about this near the #defines be in order? To avoid the
> "these values are all wrong per bspec" patches.

Yeah, good idea, I'll add a comment when merging this.

Done and merged with your irc-ack.
this made it in 3.11, is there any chance GKH will also merge this into 3.10 longterm? I'm too new in kernel development... What would need to be done to achieve that?

Regards
Jan
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux