On Wed, May 31, 2023 at 11:48:33PM +0200, Andi Shyti wrote:
> Hi Matt,
>
> On Wed, May 31, 2023 at 02:35:47PM -0700, Matt Atwood wrote:
> > Set I915_PMU_MAX_GTS to value in I915_MAX_GT, theres no reason for these
> > values to be different.
> >
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> > Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@xxxxxxxxx>
> > Cc: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>
> > Signed-off-by: Matt Atwood <matthew.s.atwood@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/i915_pmu.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_pmu.h b/drivers/gpu/drm/i915/i915_pmu.h
> > index 33d80fbaab8b..aa929d8c224a 100644
> > --- a/drivers/gpu/drm/i915/i915_pmu.h
> > +++ b/drivers/gpu/drm/i915/i915_pmu.h
> > @@ -38,7 +38,7 @@ enum {
> > __I915_NUM_PMU_SAMPLERS
> > };
> >
> > -#define I915_PMU_MAX_GTS 2
> > +#define I915_PMU_MAX_GTS 4
>
> right! Why not having
>
> #define I915_PMU_MAX_GTS I915_MAX_GT
>
> or... why having I915_PMU_MAX_GTS at all?
Originally I went the route of s/I915_PMU_MAX_GTS/I915_MAX_GT/g.
However, this introduces many changes to where you then move
I915_MAX_GT to and #include blocks in fiels that require these values.
In the end I decided it was better to keep define and just change the
value.
>
> Andi
>
> > /*
> > * How many different events we track in the global PMU mask.
> > --
> > 2.40.0
MattA
