Re: [PATCH V2] drm/i915/gt: Add workaround 14016712196

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tejas,

> > 
> > I'm wondering, though, if we can put both dummy pipe and real pipe in the
> > same command and advance the ring only once at the end... nevermind.
> 
> As we have conditional ring increments, we cant decide ring size at start in ring begin for whole bunch at once. Though double checking.

yes, you add it conditionally. Check, e.g., the control:

	if (!HAS_FLAT_CCS(rq->engine->i915))
		count = 8 + 4;
	else
		count = 8;

In the second if block. You are basically doing the same thing.

But I'm not strong with this.

Andi



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux