== Series Details == Series: drm/fbdev: Remove DRM's helpers for fbdev I/O (rev5) URL : https://patchwork.freedesktop.org/series/117671/ State : warning == Summary == Error: dim checkpatch failed c2b77e5dfd8d fbdev: Add Kconfig options to select different fb_ops helpers ff5e482b5d47 fbdev: Add initializer macros for struct fb_ops -:50: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #50: FILE: include/linux/fb.h:557: +#define FB_DEFAULT_IO_OPS \ + __FB_DEFAULT_IO_OPS_RDWR, \ + __FB_DEFAULT_IO_OPS_DRAW, \ + __FB_DEFAULT_IO_OPS_MMAP -:82: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #82: FILE: include/linux/fb.h:590: +#define FB_DEFAULT_SYS_OPS \ + __FB_DEFAULT_SYS_OPS_RDWR, \ + __FB_DEFAULT_SYS_OPS_DRAW, \ + __FB_DEFAULT_SYS_OPS_MMAP -:114: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__damage_area' - possible side-effects? #114: FILE: include/linux/fb.h:670: +#define __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, __mode) \ + static void __prefix ## _defio_fillrect(struct fb_info *info, \ + const struct fb_fillrect *rect) \ + { \ + __mode ## _fillrect(info, rect); \ + __damage_area(info, rect->dx, rect->dy, rect->width, rect->height); \ + } \ + static void __prefix ## _defio_copyarea(struct fb_info *info, \ + const struct fb_copyarea *area) \ + { \ + __mode ## _copyarea(info, area); \ + __damage_area(info, area->dx, area->dy, area->width, area->height); \ + } \ + static void __prefix ## _defio_imageblit(struct fb_info *info, \ + const struct fb_image *image) \ + { \ + __mode ## _imageblit(info, image); \ + __damage_area(info, image->dx, image->dy, image->width, image->height); \ + } -:134: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #134: FILE: include/linux/fb.h:690: +#define FB_GEN_DEFAULT_DEFERRED_IO_OPS(__prefix, __damage_range, __damage_area) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, io) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, cfb) -:134: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects? #134: FILE: include/linux/fb.h:690: +#define FB_GEN_DEFAULT_DEFERRED_IO_OPS(__prefix, __damage_range, __damage_area) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, io) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, cfb) -:138: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #138: FILE: include/linux/fb.h:694: +#define FB_GEN_DEFAULT_DEFERRED_SYS_OPS(__prefix, __damage_range, __damage_area) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys) -:138: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects? #138: FILE: include/linux/fb.h:694: +#define FB_GEN_DEFAULT_DEFERRED_SYS_OPS(__prefix, __damage_range, __damage_area) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \ + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys) -:158: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #158: FILE: include/linux/fb.h:714: +#define FB_DEFAULT_DEFERRED_OPS(__prefix) \ + __FB_DEFAULT_DEFERRED_OPS_RDWR(__prefix), \ + __FB_DEFAULT_DEFERRED_OPS_DRAW(__prefix), \ + __FB_DEFAULT_DEFERRED_OPS_MMAP(__prefix) -:158: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects? #158: FILE: include/linux/fb.h:714: +#define FB_DEFAULT_DEFERRED_OPS(__prefix) \ + __FB_DEFAULT_DEFERRED_OPS_RDWR(__prefix), \ + __FB_DEFAULT_DEFERRED_OPS_DRAW(__prefix), \ + __FB_DEFAULT_DEFERRED_OPS_MMAP(__prefix) total: 5 errors, 0 warnings, 4 checks, 133 lines checked e14669fc8202 drm/armada: Use regular fbdev I/O helpers f150181e6d5f drm/exynos: Use regular fbdev I/O helpers 96df051db90b drm/gma500: Use regular fbdev I/O helpers b80040be5a32 drm/radeon: Use regular fbdev I/O helpers 830521199632 drm/fbdev-dma: Use regular fbdev I/O helpers 1a2c3c860665 drm/omapdrm: Use regular fbdev I/O helpers f9bbb729d14a drm/tegra: Use regular fbdev I/O helpers 578b9365edb4 drm/fb-helper: Export helpers for marking damage areas 4ac0e8af7214 drm/msm: Use regular fbdev I/O helpers 8d46b2319aff drm/fbdev-generic: Implement dedicated fbdev I/O helpers 0ed42c8fdeca drm/i915: Implement dedicated fbdev I/O helpers
