On Fri, 2023-05-26 at 14:30 +0300, Jani Nikula wrote: > On Wed, 24 May 2023, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> wrote: > > On 24/05/2023 10:05, Luca Coelho wrote: > > > In order to avoid flush_scheduled_work() usage, add a dedicated > > > workqueue in the drm_i915_private structure. In this way, we don't > > > need to use the system queue anymore. > > > > > > This change is mostly mechanical and based on Tetsuo's original > > > patch[1]. > > > > > > Link: https://patchwork.freedesktop.org/series/114608/ [1] > > > Cc: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx> > > > --- > > > drivers/gpu/drm/i915/display/intel_display.c | 5 ++-- > > > .../drm/i915/display/intel_display_driver.c | 2 +- > > > drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- > > > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > > > .../drm/i915/display/intel_dp_link_training.c | 3 ++- > > > drivers/gpu/drm/i915/display/intel_drrs.c | 4 +++- > > > drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- > > > drivers/gpu/drm/i915/display/intel_fbdev.c | 3 ++- > > > drivers/gpu/drm/i915/display/intel_hdcp.c | 23 +++++++++++-------- > > > drivers/gpu/drm/i915/display/intel_hotplug.c | 18 ++++++++++----- > > > drivers/gpu/drm/i915/display/intel_opregion.c | 3 ++- > > > drivers/gpu/drm/i915/display/intel_pps.c | 4 +++- > > > drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++--- > > > .../drm/i915/gt/intel_execlists_submission.c | 5 ++-- > > > .../gpu/drm/i915/gt/intel_gt_buffer_pool.c | 10 ++++---- > > > drivers/gpu/drm/i915/gt/intel_gt_irq.c | 2 +- > > > drivers/gpu/drm/i915/gt/intel_gt_requests.c | 10 ++++---- > > > drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- > > > drivers/gpu/drm/i915/gt/intel_rps.c | 20 ++++++++-------- > > > drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 2 +- > > > drivers/gpu/drm/i915/i915_driver.c | 11 +++++++++ > > > drivers/gpu/drm/i915/i915_drv.h | 9 +++++++- > > > drivers/gpu/drm/i915/i915_request.c | 2 +- > > > drivers/gpu/drm/i915/intel_wakeref.c | 2 +- > > > 24 files changed, 99 insertions(+), 55 deletions(-) > > > > I'll take a look at the gt/ parts only since display experts need to > > okay the point Daniel raise anyway. > > There's a bunch of lockdep failures in BAT. Are they possible related to > switching to unordered wq? I have not checked those results yet, because I'll send a new version soon anyway. I tested this before, but with the dedicated wakeref workqueues, and it all passed cleanly. So it _may_ be related to that change. I'll check it. -- Cheers, Luca.
