On 15/05/2023 15:14, Rob Clark wrote:
On Mon, May 15, 2023 at 6:36 AM Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> wrote:From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> Rob, I thought maybe when you add memory stats the same field order like top(1) would feel more natural? That is client name comes last and is left justified. All other stats then come in the middle, between PID and NAME. DRM minor 0 PID render copy video video-enhance NAME 2704 |▌ || || || | kwin_x11 2734 |▏ || || || | plasmashell 3932 | || || || | krunner 4414 | || || || | xdg-desktop-por 1999477 | || || || | firefox 2162094 | || || || | thunderbirSeems like a good idea, and more in line with top/htop/nvtop
A-b/R-b? Or you go ahead with meminfo changes and I can rebase this on top later. I am okay either way.
Regards, Tvrtko
BR, -Rintel-gpu-top: Intel Alderlake_s (Gen12) @ /dev/dri/card0 - 15/ 15 MHz 99% RC6; 0.01/ 5.46 W; 34 irqs/s ENGINES BUSY MI_SEMA MI_WAIT Render/3D 1.31% |▌ | 0% 0% Blitter 0.00% | | 0% 0% Video 0.00% | | 0% 0% VideoEnhance 0.00% | | 0% 0% PID Render/3D Blitter Video VideoEnhance NAME 2734 |▏ || || || | plasmashell 2704 |▏ || || || | kwin_x11 1837 |▏ || || || | Xorg 3429732 | || || || | kwrite 2162094 | || || || | thunderbird Cc: Rob Clark <robdclark@xxxxxxxxxxxx> Tvrtko Ursulin (2): gputop: Move client name last intel_gpu_top: Move client name last tools/gputop.c | 19 +++++++++---------- tools/intel_gpu_top.c | 19 +++++++++---------- 2 files changed, 18 insertions(+), 20 deletions(-) -- 2.37.2
