On Tue, 2023-05-02 at 08:27 -0700, Ceraolo Spurio, Daniele wrote: > The new binaries that support the 2-step authentication have contain the > legacy-style binary, which we can use for loading the HuC via DMA. To > find out where this is located in the image, we need to parse the meu > manifest of the GSC binary. The manifest consist of a partition header > followed by entries, one of which contains the offset we're looking for. > Note that the DG2 GSC binary contains entries with the same names, but > it doesn't contain a full legacy binary, so we need to skip assigning > the dma offset in that case (which we can do by checking the ccs). > Also, since we're now parsing the entries, we can extract the HuC > version that way instead of using hardcoded offsets. > > Note that the meu structure will be re-used for parsing the GSC binary, > so they've been added in their own header. > > v2: fix structure names to match meu defines (s/CPT/CPD/), update commit > message, check ccs validity, drop old version location defines. > > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Cc: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx> > --- > .../drm/i915/gt/uc/intel_gsc_meu_headers.h | 74 ++++++++++ Compared line by line as per internal reviews and the spec. All looks good to me - nice to see that additional ccs validity. LGTM, Reviewed-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx>
