On Tue, Sep 03, 2013 at 04:21:04PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> It would be easier if adjusted_mode.clock would be the pipe pixel clock,
> and it actually is, except for the cases where pixel_multiplier > 1.
>
> So let's change intel_sdvo to use port_clock as the multiplied clock,
> and then we can leave adjusted_mode.clock as pipe pixel clock.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Yeah I think this makes sense. Comment updates for port_clock in
intel_drv.h to also mention the pixel multiplier would be good. Plus
adding a fuzzy port_clock check to the config comparator - teaching
intel_fuzzy_clock_check to just compare two clocks and adding a
PIPE_CONF_FUZZY_CLOCK_CHECK macro for both adjusted_mode.clock and
port_clock would be great.
Of course we still need to make those checks conditional on !HSW :(
Cheers, Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 10 ++++------
> drivers/gpu/drm/i915/intel_sdvo.c | 3 +--
> 2 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 1ed042d..3bd9a72 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4095,7 +4095,6 @@ retry:
> link_bw = intel_fdi_link_freq(dev) * MHz(100)/KHz(1)/10;
>
> fdi_dotclock = adjusted_mode->clock;
> - fdi_dotclock /= pipe_config->pixel_multiplier;
>
> lane = ironlake_get_lanes_required(fdi_dotclock, link_bw,
> pipe_config->pipe_bpp);
> @@ -7362,8 +7361,7 @@ static void i9xx_crtc_clock_get(struct intel_crtc *crtc,
> }
> }
>
> - pipe_config->adjusted_mode.clock = clock.dot *
> - pipe_config->pixel_multiplier;
> + pipe_config->adjusted_mode.clock = clock.dot;
> }
>
> static void ironlake_crtc_clock_get(struct intel_crtc *crtc,
> @@ -7408,8 +7406,7 @@ static void ironlake_crtc_clock_get(struct intel_crtc *crtc,
> clock = ((u64)link_m * (u64)link_freq);
> do_div(clock, link_n);
>
> - pipe_config->adjusted_mode.clock = clock *
> - pipe_config->pixel_multiplier;
> + pipe_config->adjusted_mode.clock = clock;
> }
>
> /** Returns the currently programmed mode of the given pipe. */
> @@ -8360,7 +8357,8 @@ encoder_retry:
> /* Set default port clock if not overwritten by the encoder. Needs to be
> * done afterwards in case the encoder adjusts the mode. */
> if (!pipe_config->port_clock)
> - pipe_config->port_clock = pipe_config->adjusted_mode.clock;
> + pipe_config->port_clock = pipe_config->adjusted_mode.clock *
> + pipe_config->pixel_multiplier;
>
> ret = intel_crtc_compute_config(to_intel_crtc(crtc), pipe_config);
> if (ret < 0) {
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 317e058..3381a52 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -1059,7 +1059,7 @@ intel_sdvo_get_preferred_input_mode(struct intel_sdvo *intel_sdvo,
>
> static void i9xx_adjust_sdvo_tv_clock(struct intel_crtc_config *pipe_config)
> {
> - unsigned dotclock = pipe_config->adjusted_mode.clock;
> + unsigned dotclock = pipe_config->port_clock;
> struct dpll *clock = &pipe_config->dpll;
>
> /* SDVO TV has fixed PLL values depend on its clock range,
> @@ -1124,7 +1124,6 @@ static bool intel_sdvo_compute_config(struct intel_encoder *encoder,
> */
> pipe_config->pixel_multiplier =
> intel_sdvo_get_pixel_multiplier(adjusted_mode);
> - adjusted_mode->clock *= pipe_config->pixel_multiplier;
>
> if (intel_sdvo->color_range_auto) {
> /* See CEA-861-E - 5.1 Default Encoding Parameters */
> --
> 1.8.1.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
