On Wed, 2023-05-10 at 11:10 +0200, Andi Shyti wrote:
> Hi Jouni,
Hi Andi, thank you for checking my patch.
>
> On Wed, May 10, 2023 at 11:50:43AM +0300, Jouni Högander wrote:
> > Fix obvious typo in intel_frontbuffer forward declaration.
> >
> > Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > index 830c11431ee8..cb362b09bf21 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > @@ -18,7 +18,7 @@
> > #include "i915_vma_resource.h"
> >
> > struct drm_i915_gem_object;
> > -struct intel_fronbuffer;
> > +struct intel_frontbuffer;
>
> Then I guess this is not necessary.
Removing it is also possible. I was thinking as i915_gem_object
contains intel_frontbuffer pointer keeping it would be more correct:
struct drm_i915_gem_object {
...
struct intel_frontbuffer __rcu *frontbuffer;
...
}
> Andi
>
> > struct intel_memory_region;
> >
> > /*
> > --
> > 2.34.1
BR,
Jouni Högander
