Re: [PATCH 20/24] drm/i915/pmu: drop kernel-doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 02, 2023 at 06:37:37PM +0300, Jani Nikula wrote:
> The comments are closer to not being kernel-doc.
> 
> drivers/gpu/drm/i915/i915_pmu.h:21: warning: cannot understand function prototype: 'enum i915_pmu_tracked_events '
> drivers/gpu/drm/i915/i915_pmu.h:32: warning: cannot understand function prototype: 'enum '
> drivers/gpu/drm/i915/i915_pmu.h:41: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>  * How many different events we track in the global PMU mask.
> 
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/i915_pmu.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pmu.h b/drivers/gpu/drm/i915/i915_pmu.h
> index 449057648f39..c30f43319a78 100644
> --- a/drivers/gpu/drm/i915/i915_pmu.h
> +++ b/drivers/gpu/drm/i915/i915_pmu.h
> @@ -14,7 +14,7 @@
>  
>  struct drm_i915_private;
>  
> -/**
> +/*
>   * Non-engine events that we need to track enabled-disabled transition and
>   * current state.
>   */
> @@ -25,7 +25,7 @@ enum i915_pmu_tracked_events {
>  	__I915_PMU_TRACKED_EVENT_COUNT, /* count marker */
>  };
>  
> -/**
> +/*
>   * Slots used from the sampling timer (non-engine events) with some extras for
>   * convenience.
>   */
> @@ -37,7 +37,7 @@ enum {
>  	__I915_NUM_PMU_SAMPLERS
>  };
>  
> -/**
> +/*
>   * How many different events we track in the global PMU mask.
>   *
>   * It is also used to know to needed number of event reference counters.
> -- 
> 2.39.2
> 



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux