== Series Details == Series: mtl: add support for pmdemand (rev2) URL : https://patchwork.freedesktop.org/series/116949/ State : warning == Summary == Error: dim checkpatch failed 5016f41822c8 drm/i915: fix the derating percentage for MTL 058a5643fd59 drm/i915: update the QGV point frequency calculations c577a850a946 drm/i915: store the peak bw per QGV point ed6ff8e568de drm/i915: extract intel_bw_check_qgv_points() 55901493e37d drm/i915: modify max_bw to return index to intel_bw_info 3625a67eea00 drm/i915/mtl: find best QGV point and configure sagv 48f2141f0a8f drm/i915/mtl: Add support for PM DEMAND Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:92: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #92: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:350: + struct mutex lock; -:165: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #165: new file mode 100644 -:276: CHECK:LINE_SPACING: Please don't use multiple blank lines #276: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:107: + + -:475: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects? #475: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:306: +#define UPDATE_PMDEMAND_VAL(val, F, f) do { \ + val &= (~(XELPDP_PMDEMAND_##F##_MASK)); \ + val |= (XELPDP_PMDEMAND_##F((u32)(old ? max(old->f, new->f) : new->f))); \ +} while (0) -:475: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'val' may be better as '(val)' to avoid precedence issues #475: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:306: +#define UPDATE_PMDEMAND_VAL(val, F, f) do { \ + val &= (~(XELPDP_PMDEMAND_##F##_MASK)); \ + val |= (XELPDP_PMDEMAND_##F((u32)(old ? max(old->f, new->f) : new->f))); \ +} while (0) -:475: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects? #475: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:306: +#define UPDATE_PMDEMAND_VAL(val, F, f) do { \ + val &= (~(XELPDP_PMDEMAND_##F##_MASK)); \ + val |= (XELPDP_PMDEMAND_##F((u32)(old ? max(old->f, new->f) : new->f))); \ +} while (0) -:475: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues #475: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:306: +#define UPDATE_PMDEMAND_VAL(val, F, f) do { \ + val &= (~(XELPDP_PMDEMAND_##F##_MASK)); \ + val |= (XELPDP_PMDEMAND_##F((u32)(old ? max(old->f, new->f) : new->f))); \ +} while (0) -:533: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #533: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.c:364: +static bool intel_pmdemand_state_changed( -:605: CHECK:LINE_SPACING: Please don't use multiple blank lines #605: FILE: drivers/gpu/drm/i915/display/intel_pmdemand.h:24: + + -:623: CHECK:LINE_SPACING: Please don't use multiple blank lines #623: FILE: drivers/gpu/drm/i915/i915_irq.c:60: + -:689: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #689: FILE: drivers/gpu/drm/i915/i915_reg.h:4519: +#define XELPDP_PMDEMAND_QCLK_GV_BW(x) REG_FIELD_PREP(XELPDP_PMDEMAND_QCLK_GV_BW_MASK, x) -:691: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #691: FILE: drivers/gpu/drm/i915/i915_reg.h:4521: +#define XELPDP_PMDEMAND_VOLTAGE_INDEX(x) REG_FIELD_PREP(XELPDP_PMDEMAND_VOLTAGE_INDEX_MASK, x) -:693: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #693: FILE: drivers/gpu/drm/i915/i915_reg.h:4523: +#define XELPDP_PMDEMAND_QCLK_GV_INDEX(x) REG_FIELD_PREP(XELPDP_PMDEMAND_QCLK_GV_INDEX_MASK, x) -:695: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #695: FILE: drivers/gpu/drm/i915/i915_reg.h:4525: +#define XELPDP_PMDEMAND_PIPES(x) REG_FIELD_PREP(XELPDP_PMDEMAND_PIPES_MASK, x) -:697: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #697: FILE: drivers/gpu/drm/i915/i915_reg.h:4527: +#define XELPDP_PMDEMAND_DBUFS(x) REG_FIELD_PREP(XELPDP_PMDEMAND_DBUFS_MASK, x) -:703: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #703: FILE: drivers/gpu/drm/i915/i915_reg.h:4533: +#define XELPDP_PMDEMAND_CDCLK_FREQ(x) REG_FIELD_PREP(XELPDP_PMDEMAND_CDCLK_FREQ_MASK, x) -:705: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #705: FILE: drivers/gpu/drm/i915/i915_reg.h:4535: +#define XELPDP_PMDEMAND_DDICLK_FREQ(x) REG_FIELD_PREP(XELPDP_PMDEMAND_DDICLK_FREQ_MASK, x) -:707: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #707: FILE: drivers/gpu/drm/i915/i915_reg.h:4537: +#define XELPDP_PMDEMAND_SCALERS(x) REG_FIELD_PREP(XELPDP_PMDEMAND_SCALERS_MASK, x) total: 0 errors, 9 warnings, 9 checks, 639 lines checked f53338fb7529 drm/i915/display: provision to suppress drm_warn in intel_get_crtc_new_encoder -:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #50: FILE: drivers/gpu/drm/i915/display/intel_display.c:788: + drm_WARN(state->base.dev, num_encoders != 1, + "%d encoders for pipe %c\n", total: 0 errors, 0 warnings, 1 checks, 95 lines checked
