On Thu, 2023-04-06 at 15:26 -0700, John.C.Harrison@xxxxxxxxx wrote: > From: John Harrison <John.C.Harrison@xxxxxxxxx> > > Don't use GEN9 as a prefix for register lists that contain all GEN8 > registers. alan:snip alan: This patch as a stand-along looks good, so I'll provide the RB but take note of the comment below that should be reflected by decision on the review comments of patch #1 so this patch might change from GEN9_foo-from-patch-1 to GEN8_foo-from-patch-1. Reviewed-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx> > -/* GEN9 - Global */ > +/* GEN8 - Global */ > static const struct __guc_mmio_reg_descr default_global_regs[] = { > COMMON_BASE_GLOBAL, > - COMMON_GEN9BASE_GLOBAL, > - GEN9_GLOBAL, > + COMMON_GEN8BASE_GLOBAL, > + GEN8_GLOBAL, alan: see patch comment about "COMMON_GLOBAL" vs "GLOBAL" confusion.