On Thu, 2023-04-06 at 15:26 -0700, John.C.Harrison@xxxxxxxxx wrote: > From: John Harrison <John.C.Harrison@xxxxxxxxx> > > Don't use 'xe_lp*' prefixes for register lists that are common with > Gen8. alan:snip > @@ -177,32 +177,32 @@ static const struct __guc_mmio_reg_descr empty_regs_list[] = { > static const struct __guc_mmio_reg_descr_group default_lists[] = { alan:snip > - MAKE_REGLIST(xe_lpd_gsc_inst_regs, PF, ENGINE_INSTANCE, GUC_GSC_OTHER_CLASS), > + MAKE_REGLIST(empty_regs_list, PF, ENGINE_INSTANCE, GUC_GSC_OTHER_CLASS), alan: i missed from the review of Daniele's GSC enabling patch - thanks for catching this. > {} > }; > > simple patch - all looks good: Reviewed-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx>