Thomas Zimmermann <tzimmermann@xxxxxxx> writes: [...] >>> +EXPORT_SYMBOL(__aperture_remove_legacy_vga_devices); >> >> I would just call this symbol aperture_remove_legacy_vga_devices() as >> mentioned, the fact that aperture_remove_conflicting_pci_devices() use it >> internally is an implementation detail IMO. But it's an exported symbol so >> the naming should be consistent. > > That prefix __ is supposed to indicate that it's not a all-in-one > solution. Most of all, it doesn't do sysfb_disable(). The helper is > meant to be used as part of a larger function. I tried to outline this > in the comment, where I say that drivers should first aquire framebuffer > ownership and then call this helper. If naming isn't a showstopper, I'd > like to keep the underscores. > Sure, I see that we have other symbols exported in DRM that have a __ prefix in their name. So maybe I am the one who was confused on the meaning of it. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
