Re: [PATCH 1/5] drm/i915/ttm: Add I915_BO_PREALLOC

"Das, Nirmoy" <nirmoy.das@xxxxxxxxxxxxxxx> · Wed, 5 Apr 2023 14:36:20 +0200

    Hi Andi,

    On 4/5/2023 1:53 PM, Andi Shyti wrote:

      Hi Nirmoy,

            Add a mechanism to keep existing data when creating
a ttm object with I915_BO_ALLOC_USER flag.

          why do we need this mechanism? What was the logic behind? These
are all questions people might have when checking this commit.
Please be a bit more explicative.

Agree, the commit message is bit short. I will add more content in next
revision.

      you don't need to send a new version just for this commit log.

You could just propose a new commit log in the reply and if it's
OK, add it before pushing it.

    Let me know what do you think about: 

    Add a mechanism to preserve existing data when creating a TTM
    object with the I915_BO_ALLOC_USER flag. This will be used in the subsequent
    patch where the I915_BO_ALLOC_USER flag will be applied to the framebuffer
    object. For a pre-allocated framebuffer without the I915_BO_PREALLOC flag,
    TTM would clear the content, which is not desirable.

    Thanks,
    Nirmoy

As you wish.

Andi

            Cc: Matthew Auld <matthew.auld@xxxxxxxxx>
Cc: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
Cc: Imre Deak <imre.deak@xxxxxxxxx>
Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>

          Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>

Thanks,

Nirmoy

          Thanks,
Andi