Hi Mark, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next-fixes] [also build test WARNING on drm/drm-next linus/master v6.3-rc4 next-20230331] [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mark-Yacoub/drm-hdcp-Add-drm_hdcp_atomic_check/20230401-061425 base: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes patch link: https://lore.kernel.org/r/20230331221213.1691997-5-markyacoub%40google.com patch subject: [PATCH v8 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20230401/202304010815.5iVFI5nv-lkp@xxxxxxxxx/config) compiler: riscv64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/82a092e7e090cdeb3ff18498e6ad671906268631 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mark-Yacoub/drm-hdcp-Add-drm_hdcp_atomic_check/20230401-061425 git checkout 82a092e7e090cdeb3ff18498e6ad671906268631 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/gpu/drm/display/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202304010815.5iVFI5nv-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/display/drm_hdcp_helper.c:719: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Check if the sink is capable of HDCP 1.x. DisplayPort has a dedicated bit drivers/gpu/drm/display/drm_hdcp_helper.c:742: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Check if the sink is capable of HDCP 1.x. HDMI spec states that transmitters drivers/gpu/drm/display/drm_hdcp_helper.c:1633: warning: Function parameter or member 'aux' not described in 'drm_hdcp_helper_initialize_dp' vim +719 drivers/gpu/drm/display/drm_hdcp_helper.c 717 718 /** > 719 * Check if the sink is capable of HDCP 1.x. DisplayPort has a dedicated bit 720 * for this in DPCD. 721 * 722 * @data: pointer to the HDCP helper data. 723 * @capable: pointer to a bool which will contain true if the sink is capable. 724 * 725 * Returns: 726 * -errno if the transacation between source and sink fails. 727 */ 728 int drm_hdcp_helper_hdcp1_capable_dp(struct drm_hdcp_helper_data *data, 729 bool *capable) 730 { 731 int ret; 732 u8 bcaps; 733 734 ret = data->funcs->remote_read(data, data->hdcp1_lut->bcaps, &bcaps, 1); 735 *capable = !ret && (bcaps & DP_BCAPS_HDCP_CAPABLE); 736 737 return 0; 738 } 739 EXPORT_SYMBOL(drm_hdcp_helper_hdcp1_capable_dp); 740 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
