On Wed, Mar 29, 2023 at 10:04:45PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Define CUR_CHICKEN so we don't have to remember the offset. > Looks like it's getting introduced in mtl. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> On the patchset: Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_reg.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 275ec891468c..f6a6f3b6c603 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -3989,6 +3989,7 @@ > #define CUR_FBC_EN REG_BIT(31) > #define CUR_FBC_HEIGHT_MASK REG_GENMASK(7, 0) > #define CUR_FBC_HEIGHT(h) REG_FIELD_PREP(CUR_FBC_HEIGHT_MASK, (h)) > +#define _CUR_CHICKEN_A 0x700a4 /* mtl+ */ > #define _CURASURFLIVE 0x700ac /* g4x+ */ > #define _CURBCNTR 0x700c0 > #define _CURBBASE 0x700c4 > @@ -4003,6 +4004,7 @@ > #define CURPOS(pipe) _MMIO_CURSOR2(pipe, _CURAPOS) > #define CURSIZE(pipe) _MMIO_CURSOR2(pipe, _CURASIZE) > #define CUR_FBC_CTL(pipe) _MMIO_CURSOR2(pipe, _CUR_FBC_CTL_A) > +#define CUR_CHICKEN(pipe) _MMIO_CURSOR2(pipe, _CUR_CHICKEN_A) > #define CURSURFLIVE(pipe) _MMIO_CURSOR2(pipe, _CURASURFLIVE) > > #define CURSOR_A_OFFSET 0x70080 > -- > 2.39.2 >