Hi, > -----Original Message----- > From: Saarinen, Jani > Sent: tiistai 28. maaliskuuta 2023 9.35 > To: Zhang, Rui <rui.zhang@xxxxxxxxx>; Deak, Imre <imre.deak@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: RE: ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous > smp_num_siblings on Intel Hybrid platform > > Hi. > > -----Original Message----- > > From: Zhang, Rui <rui.zhang@xxxxxxxxx> > > Sent: tiistai 28. maaliskuuta 2023 4.57 > > To: Deak, Imre <imre.deak@xxxxxxxxx> > > Cc: Saarinen, Jani <jani.saarinen@xxxxxxxxx>; > > intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Subject: Re: ✗ Fi.CI.BAT: failure for x86/topology: fix erroneous > > smp_num_siblings on Intel Hybrid platform > > > > On Tue, 2023-03-28 at 09:14 +0800, Zhang Rui wrote: > > > Hi, Imre, > > > > > > Thanks for raising this. > > > > > > On Tue, 2023-03-28 at 00:26 +0300, Imre Deak wrote: > > > > Hi Rui, > > > > > > > > after applying your > > > > "x86/topology: fix erroneous smp_num_siblings on Intel Hybrid > > > > platform" > > > > > > > > fix on the drm-tip tree (see the patchwork URL below) the CI tests > > > > show some regression on a HSW and a KBL machine (see [2] and [4] > > > > below) in the i915 driver. However I think they can't be related > > > > to your changes, since on these machines all cores will report the > > > > same number of CPU siblings. > > > > > > Right. > > > > > > > Could you confirm this and that in general the reported siblings > > > > can only vary on platforms with both E and P cores (ADL-P being > > > > the first such platform)? > > > > > > Right. > > > > > > I don't think the patch could bring any change related. > > > It only affects hybrid platforms. > > > > Is this topology fix patch the only patch applied? or together with some other > patches? > This only. > > > > I can hardly imagine that the fix patch can trigger such issues, so I > > suspect they are intermittent issues. say is the regression 100% reproducible? > This is not regression. I assume drm-tip misses this patch (as was not part of 6.3rc > yet.) Ignore this comment, badly read mail only. I assume it is hard to day as this test is done on CI (pre-merge) Let Imre to comment here. > > > does the warning/failure ever show without the patch? > Yes, On our local (3) system's seen on all. Again. Ignore this too. > > > > BTW, I just happened to see this thread > > > https://lore.kernel.org/all/DM8PR11MB565580BCF44661B6A392F0CEE08B9@DM8 > > P > > R11MB5655.namprd11.prod.outlook.com/ > > If the problem on hand has been verified to be not related with the > > topology fix, can we update in this thread as well? > > https://lore.kernel.org/all/20230323015640.27906-1-rui.zhang@xxxxxxxxx > > / This is another issue that the patch fixes. And it's better to have > > a Buglink/Tested-by tag in the commit. > > > > thanks, > > rui > > > > > > > > Thanks, > > > rui > > > > Thanks, > > > > Imre > > > > > > > > On Mon, Mar 27, 2023 at 07:02:25PM +0000, Patchwork wrote: > > > > > == Series Details == > > > > > > > > > > Series: x86/topology: fix erroneous smp_num_siblings on Intel > > > > > Hybrid platform > > > > > URL : https://patchwork.freedesktop.org/series/115661/ > > > > > State : failure > > > > > > > > > > == Summary == > > > > > > > > > > CI Bug Log - changes from CI_DRM_12921 -> Patchwork_115661v1 > > > > > ==================================================== > > > > > > > > > > Summary > > > > > ------- > > > > > > > > > > **FAILURE** > > > > > > > > > > Serious unknown changes coming with Patchwork_115661v1 > > > > > absolutely need to be > > > > > verified manually. > > > > > > > > > > If you think the reported changes have nothing to do with the > > > > > changes > > > > > introduced in Patchwork_115661v1, please notify your bug team > > > > > to allow them > > > > > to document this new failure mode, which will reduce false > > > > > positives in CI. > > > > > > > > > > External URL: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/index. > > > > > html > > > > > > > > > > Participating hosts (37 -> 37) > > > > > ------------------------------ > > > > > > > > > > No changes in participating hosts > > > > > > > > > > Possible new issues > > > > > ------------------- > > > > > > > > > > Here are the unknown changes that may have been introduced in > > > > > Patchwork_115661v1: > > > > > > > > > > ### IGT changes ### > > > > > > > > > > #### Possible regressions #### > > > > > > > > > > * igt@i915_selftest@live@hangcheck: > > > > > - fi-hsw-4770: [PASS][1] -> [DMESG-WARN][2] > > > > > [1]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/fi-hsw- > > 4770/igt@i915_selftest@live@xxxxxxxxxxxxxx > > > > > [2]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/fi-h > > > > > sw -4770/igt@i915_selftest@live@xxxxxxxxxxxxxx > > > > > > > > > > > > > > > #### Suppressed #### > > > > > > > > > > The following results come from untrusted machines, tests, or > > > > > statuses. > > > > > They do not affect the overall result. > > > > > > > > > > * igt@fbdev@info: > > > > > - {bat-kbl-2}: [SKIP][3] ([fdo#109271]) -> [ABORT][4] > > > > > [3]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-kbl- > > 2/igt@fbdev@xxxxxxxxx > > > > > [4]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat- > > > > > kb > > > > > l-2/igt@fbdev@xxxxxxxxx > > > > > > > > > > > > > > > Known issues > > > > > ------------ > > > > > > > > > > Here are the changes found in Patchwork_115661v1 that come > > > > > from known issues: > > > > > > > > > > ### IGT changes ### > > > > > > > > > > #### Issues hit #### > > > > > > > > > > * igt@gem_exec_suspend@basic-s3@lmem0: > > > > > - bat-dg2-11: [PASS][5] -> [INCOMPLETE][6] > > > > > ([i915#6311]) > > > > > [5]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-dg2- > > 11/igt@gem_exec_suspend@basic-s3@xxxxxxxxxx > > > > > [6]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat- > > > > > dg 2-11/igt@gem_exec_suspend@basic-s3@xxxxxxxxxx > > > > > > > > > > * igt@i915_selftest@live@reset: > > > > > - bat-rpls-1: [PASS][7] -> [ABORT][8] ([i915#4983]) > > > > > [7]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-rpls- > > 1/igt@i915_selftest@live@xxxxxxxxxx > > > > > [8]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat- > > > > > rp ls-1/igt@i915_selftest@live@xxxxxxxxxx > > > > > > > > > > * igt@i915_selftest@live@slpc: > > > > > - bat-rpls-2: NOTRUN -> [DMESG-FAIL][9] ([i915#6367] > > > > > / > > > > > [i915#7913] / [i915#7996]) > > > > > [9]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat- > > > > > rp ls-2/igt@i915_selftest@live@xxxxxxxxx > > > > > > > > > > * igt@i915_suspend@basic-s3-without-i915: > > > > > - bat-rpls-2: NOTRUN -> [ABORT][10] ([i915#6687] / > > > > > [i915#7978]) > > > > > [10]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat- > > > > > rp ls-2/igt@i915_suspend@xxxxxxxxxxxxxxxxxxxxxxxxxx > > > > > > > > > > * > > > > > igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d- > > > > > dp-1: > > > > > - bat-dg2-8: [PASS][11] -> [FAIL][12] ([i915#7932]) > > > > > [11]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-dg2- > > 8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@xxxxxxxxxxxxxx > > ml > > > > > [12]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat- > > > > > dg > > > > > 2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d > > > > > -d > > > > > p-1.html > > > > > > > > > > > > > > > #### Possible fixes #### > > > > > > > > > > * igt@i915_selftest@live@gt_heartbeat: > > > > > - fi-kbl-soraka: [DMESG-FAIL][13] ([i915#5334] / > > > > > [i915#7872]) -> [PASS][14] > > > > > [13]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/fi-kbl- > > soraka/igt@i915_selftest@live@gt_heartbeat.html > > > > > [14]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/fi-k > > > > > bl -soraka/igt@i915_selftest@live@gt_heartbeat.html > > > > > > > > > > * igt@i915_selftest@live@reset: > > > > > - bat-rpls-2: [ABORT][15] ([i915#4983] / [i915#7913]) > > > > > -> [PASS][16] > > > > > [15]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12921/bat-rpls- > > 2/igt@i915_selftest@live@xxxxxxxxxx > > > > > [16]: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/bat- > > > > > rp ls-2/igt@i915_selftest@live@xxxxxxxxxx > > > > > > > > > > > > > > > {name}: This element is suppressed. This means it is ignored > > > > > when computing > > > > > the status of the difference (SUCCESS, WARNING, or > > > > > FAILURE). > > > > > > > > > > [fdo#109271]: > > > > > https://bugs.freedesktop.org/show_bug.cgi?id=109271 > > > > > [i915#4983]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/4983 > > > > > [i915#5334]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/5334 > > > > > [i915#6311]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/6311 > > > > > [i915#6367]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/6367 > > > > > [i915#6687]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/6687 > > > > > [i915#7872]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/7872 > > > > > [i915#7913]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/7913 > > > > > [i915#7932]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/7932 > > > > > [i915#7978]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/7978 > > > > > [i915#7996]: > > > > > https://gitlab.freedesktop.org/drm/intel/issues/7996 > > > > > > > > > > > > > > > Build changes > > > > > ------------- > > > > > > > > > > * Linux: CI_DRM_12921 -> Patchwork_115661v1 > > > > > > > > > > CI-20190529: 20190529 > > > > > CI_DRM_12921: 3de6040ce9900a94ec626662d5c6a227b37eeb1c @ > > > > > git://anongit.freedesktop.org/gfx-ci/linux > > > > > IGT_7221: 4b77c6d85024d22ca521d510f8eee574128fe04f @ > > > > > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > > > > > Patchwork_115661v1: 3de6040ce9900a94ec626662d5c6a227b37eeb1c @ > > > > > git://anongit.freedesktop.org/gfx-ci/linux > > > > > > > > > > > > > > > ### Linux commits > > > > > > > > > > 83d9e76610d5 x86/topology: fix erroneous smp_num_siblings on > > > > > Intel Hybrid platform > > > > > > > > > > == Logs == > > > > > > > > > > For more details see: > > > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115661v1/index. > > > > > html