> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Imre
> Deak
> Sent: Thursday, March 23, 2023 4:20 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 17/29] drm/i915/tc: Remove redundant wakeref=0
> check from unblock_tc_cold()
>
> After the previous patch unblock_tc_cold() will not be called in a disconnected
> mode, so the wakeref passed to it will be always non-zero.
> Remove the redundant check.
>
Reviewed-by: Mika Kahola <mika.kahola@xxxxxxxxx>
> Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_tc.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c
> b/drivers/gpu/drm/i915/display/intel_tc.c
> index 253ab30c34f7a..21c6ef8064883 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -150,14 +150,6 @@ tc_cold_unblock(struct intel_tc_port *tc, enum
> intel_display_power_domain domain {
> struct drm_i915_private *i915 = tc_to_i915(tc);
>
> - /*
> - * wakeref == -1, means some error happened saving save_depot_stack
> but
> - * power should still be put down and 0 is a invalid save_depot_stack
> - * id so can be used to skip it for non TC legacy ports.
> - */
> - if (wakeref == 0)
> - return;
> -
> intel_display_power_put(i915, domain, wakeref); }
>
> --
> 2.37.1
