On Fri, 2023-03-03 at 17:34 -0800, Ceraolo Spurio, Daniele wrote: > > On 2/27/2023 6:21 PM, Alan Previn wrote: > > Add MTL's function for ARB session creation using PXP firmware > > version 4.3 ABI structure format. > alan:snip > > + ret = gsccs_send_message_retry_complete(pxp, > > + &msg_in, sizeof(msg_in), > > + &msg_out, sizeof(msg_out), NULL); > > + if (ret) > > + drm_warn(&i915->drm, "Failed to send gsccs msg for creating-session-%d: ret=[%d]\n", > > + arb_session_id, ret); > > + else if (msg_out.header.status != 0x0) > > + drm_warn(&i915->drm, "PXP firmware failed on creating-session-%d: status=0x%08x\n", > > + arb_session_id, msg_out.header.status); > > Should this follow the same log style as > https://patchwork.freedesktop.org/patch/521431/? same for the function > below. alan: yeah - i was planning to update once the other got an Rb which is just did. In the coming rev7, I'll probably duplicate some of the fw-err-to-string function for both GSCCS and TEE in the event new or existing error conditions are differently determined as platform persisting issue or runtime issues. alan:snip > > +void intel_pxp_gsccs_end_arb_fw_session(struct intel_pxp *pxp, u32 session_id) > > +{ > > + struct drm_i915_private *i915 = pxp->ctrl_gt->i915; > > + struct pxp42_inv_stream_key_in msg_in = {0}; > > + struct pxp42_inv_stream_key_out msg_out = {0}; > > + int ret = 0; > > + > > + memset(&msg_in, 0, sizeof(msg_in)); > > + memset(&msg_out, 0, sizeof(msg_out)); > > You're already initializing the structs to zero with "= {0}" > alan: oops - copy+paste error - will fix.
