Hi Imre, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-tc-Group-the-TC-PHY-setup-query-functions-per-platform/20230323-222328 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230323142035.1432621-2-imre.deak%40intel.com patch subject: [PATCH 01/29] drm/i915/tc: Group the TC PHY setup/query functions per platform config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20230324/202303240014.FNfWYmf7-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/7b85ed1627f7c16b7ff080b604d35d729c70313f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Imre-Deak/drm-i915-tc-Group-the-TC-PHY-setup-query-functions-per-platform/20230323-222328 git checkout 7b85ed1627f7c16b7ff080b604d35d729c70313f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303240014.FNfWYmf7-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/i915/display/intel_tc.c:264: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * ICL TC PHY handlers drivers/gpu/drm/i915/display/intel_tc.c:457: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * ADLP TC PHY handlers drivers/gpu/drm/i915/display/intel_tc.c:535: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Generic TC PHY handlers drivers/gpu/drm/i915/display/intel_tc.c:1026: warning: Function parameter or member 'work' not described in 'intel_tc_port_disconnect_phy_work' drivers/gpu/drm/i915/display/intel_tc.c:1026: warning: Excess function parameter 'dig_port' description in 'intel_tc_port_disconnect_phy_work' vim +264 drivers/gpu/drm/i915/display/intel_tc.c 262 263 /** > 264 * ICL TC PHY handlers 265 * ------------------- 266 */ 267 static u32 icl_tc_port_live_status_mask(struct intel_digital_port *dig_port) 268 { 269 struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev); 270 u32 isr_bit = i915->display.hotplug.pch_hpd[dig_port->base.hpd_pin]; 271 u32 mask = 0; 272 u32 val; 273 274 val = intel_de_read(i915, PORT_TX_DFLEXDPSP(dig_port->tc_phy_fia)); 275 276 if (val == 0xffffffff) { 277 drm_dbg_kms(&i915->drm, 278 "Port %s: PHY in TCCOLD, nothing connected\n", 279 dig_port->tc_port_name); 280 return mask; 281 } 282 283 if (val & TC_LIVE_STATE_TBT(dig_port->tc_phy_fia_idx)) 284 mask |= BIT(TC_PORT_TBT_ALT); 285 if (val & TC_LIVE_STATE_TC(dig_port->tc_phy_fia_idx)) 286 mask |= BIT(TC_PORT_DP_ALT); 287 288 if (intel_de_read(i915, SDEISR) & isr_bit) 289 mask |= BIT(TC_PORT_LEGACY); 290 291 /* The sink can be connected only in a single mode. */ 292 if (!drm_WARN_ON_ONCE(&i915->drm, hweight32(mask) > 1)) 293 tc_port_fixup_legacy_flag(dig_port, mask); 294 295 return mask; 296 } 297 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
