Hi Radhakrishna, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Radhakrishna-Sripada/drm-i915-mtl-Squashed-Phy-Support/20230318-090025 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230318005852.2303937-2-radhakrishna.sripada%40intel.com patch subject: [PATCH 1/4] drm/i915/mtl: Squashed Phy Support config: x86_64-randconfig-a004-20230320 (https://download.01.org/0day-ci/archive/20230321/202303212045.4ONidwhT-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/09eaa092cb75c3ac2a82dbf3b83bff437be2abfa git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Radhakrishna-Sripada/drm-i915-mtl-Squashed-Phy-Support/20230318-090025 git checkout 09eaa092cb75c3ac2a82dbf3b83bff437be2abfa # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303212045.4ONidwhT-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/gpu/drm/i915/display/intel_cx0_phy.c:2174:13: error: variable 'multiplier' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] } else if (pll_state->mplla[6] & C20_MPLLA_FRACEN) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_cx0_phy.c:2184:10: note: uninitialized use occurs here tmp2 = (multiplier << 15) + frac_quot + DIV_ROUND_CLOSEST(frac_rem,frac_den); ^~~~~~~~~~ drivers/gpu/drm/i915/display/intel_cx0_phy.c:2174:9: note: remove the 'if' if its condition is always true } else if (pll_state->mplla[6] & C20_MPLLA_FRACEN) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_cx0_phy.c:2162:25: note: initialize the variable 'multiplier' to silence this warning unsigned int multiplier, refclk = 38400; ^ = 0 1 error generated. vim +2174 drivers/gpu/drm/i915/display/intel_cx0_phy.c 2157 2158 int intel_c20pll_calc_port_clock(struct intel_encoder *encoder, 2159 const struct intel_c20pll_state *pll_state) 2160 { 2161 unsigned int frac_quot = 0, frac_rem = 0, frac_den = 1; 2162 unsigned int multiplier, refclk = 38400; 2163 unsigned ref_clk_mpllb_div = 0; 2164 unsigned fb_clk_div4_en = 0; 2165 unsigned long tmp1, tmp2; 2166 2167 if (pll_state->mpllb[6] & C20_MPLLB_FRACEN) { 2168 multiplier = REG_FIELD_GET(C20_MULTIPLIER_MASK, pll_state->mpllb[0]); 2169 ref_clk_mpllb_div = REG_FIELD_GET(C20_REF_CLK_MPLLB_DIV_MASK, pll_state->mpllb[6]); 2170 fb_clk_div4_en = REG_FIELD_GET(C20_FB_CLK_DIV4_EN, pll_state->mpllb[6]); 2171 frac_den = pll_state->mpllb[7]; 2172 frac_quot = pll_state->mpllb[8]; 2173 frac_rem = pll_state->mpllb[9]; > 2174 } else if (pll_state->mplla[6] & C20_MPLLA_FRACEN) { 2175 multiplier = REG_FIELD_GET(C20_MULTIPLIER_MASK, pll_state->mplla[0]); 2176 ref_clk_mpllb_div = REG_FIELD_GET(C20_REF_CLK_MPLLB_DIV_MASK, pll_state->mpllb[6]); 2177 fb_clk_div4_en = REG_FIELD_GET(C20_FB_CLK_DIV4_EN, pll_state->mpllb[6]); 2178 frac_den = pll_state->mpllb[7]; 2179 frac_quot = pll_state->mplla[8]; 2180 frac_rem = pll_state->mplla[9]; 2181 } 2182 2183 tmp1 = DIV_ROUND_CLOSEST(refclk * (1 << (1 + fb_clk_div4_en)), 1 << ref_clk_mpllb_div); 2184 tmp2 = (multiplier << 15) + frac_quot + DIV_ROUND_CLOSEST(frac_rem,frac_den); 2185 2186 return DIV_ROUND_CLOSEST((tmp1 * tmp2) >> 17, 10); 2187 } 2188 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
