On Thu, Mar 16, 2023 at 03:17:10PM +0200, Imre Deak wrote: > This patchset fixes a few issues on TypeC ports, related to the legacy > port handling, HW state readout/verification. It also fixes an issue on > TC port/MST outputs during system suspend/resume, where the modeset > restoring the pre-suspend state fails atm. > > Tested on ICL, TGL, ADLP. > > Imre Deak (14): > drm/i915/tc: Abort DP AUX transfer on a disconnected TC port > drm/i915/tc: Fix TC port link ref init for DP MST during HW readout > drm/i915/tc: Fix the ICL PHY ownership check in TC-cold state > drm/i915/tc: Fix system resume MST mode restore for DP-alt sinks > drm/i915/tc: Wait for IOM/FW PHY initialization of legacy TC ports > drm/i915/tc: Factor out helpers converting HPD mask to TC mode > drm/i915/tc: Fix target TC mode for a disconnected legacy port > drm/i915/tc: Fix TC mode for a legacy port if the PHY is not ready > drm/i915/tc: Fix initial TC mode on disabled legacy ports > drm/i915/tc: Make the TC mode readout consistent in all PHY states > drm/i915/tc: Assume a TC port is legacy if VBT says the port has HDMI > drm/i915: Add encoder hook to get the PLL type used by TC ports > drm/i915/tc: Factor out a function querying active links on a TC port > drm/i915/tc: Check the PLL type used by an enabled TC port Read through it and didn't spot anything egregious. Just a few minor nits for which I replied separately. Apart from those the series is Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > drivers/gpu/drm/i915/display/intel_ddi.c | 44 ++- > drivers/gpu/drm/i915/display/intel_ddi.h | 3 + > .../drm/i915/display/intel_display_types.h | 6 + > drivers/gpu/drm/i915/display/intel_dp_aux.c | 15 +- > drivers/gpu/drm/i915/display/intel_tc.c | 319 ++++++++++++++---- > drivers/gpu/drm/i915/display/intel_tc.h | 1 + > 6 files changed, 320 insertions(+), 68 deletions(-) > > -- > 2.37.1 -- Ville Syrjälä Intel
