Hi Jani, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-debugfs-add-crtc-i915_pipe-debugfs-file/20230317-205512 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230317125352.198042-1-jani.nikula%40intel.com patch subject: [PATCH 1/2] drm/i915/debugfs: switch crtc debugfs to struct intel_crtc config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230317/202303172307.KAbTCHfP-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/506415b57ce52f43962e9e766ff8dd5410fe3051 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jani-Nikula/drm-i915-debugfs-add-crtc-i915_pipe-debugfs-file/20230317-205512 git checkout 506415b57ce52f43962e9e766ff8dd5410fe3051 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303172307.KAbTCHfP-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/gpu/drm/i915/display/intel_display_debugfs.c: In function 'crtc_updates_add': >> drivers/gpu/drm/i915/display/intel_display_debugfs.c:810:59: error: 'struct intel_crtc' has no member named 'debugfs_entry' 810 | debugfs_create_file("i915_update_info", 0644, crtc->debugfs_entry, | ^~ vim +810 drivers/gpu/drm/i915/display/intel_display_debugfs.c 829270e4552e9e Chris Wilson 2020-12-02 807 506415b57ce52f Jani Nikula 2023-03-17 808 static void crtc_updates_add(struct intel_crtc *crtc) 829270e4552e9e Chris Wilson 2020-12-02 809 { 829270e4552e9e Chris Wilson 2020-12-02 @810 debugfs_create_file("i915_update_info", 0644, crtc->debugfs_entry, 506415b57ce52f Jani Nikula 2023-03-17 811 crtc, &crtc_updates_fops); 829270e4552e9e Chris Wilson 2020-12-02 812 } 829270e4552e9e Chris Wilson 2020-12-02 813 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
