Re: [PATCH v4 00/10] drm/i915: use ref_tracker library for tracking wakerefs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

Gently ping on the series.

Regards
Andrzej

On 06.03.2023 17:31, Andrzej Hajda wrote:
This is revived patchset improving ref_tracker library and converting
i915 internal tracker to ref_tracker.
The old thread ended without consensus about small kernel allocations,
which are performed under spinlock.
I have tried to solve the problem by splitting the calls, but it results
in complicated API, so I went back to original solution.
If there are better solutions I am glad to discuss them.
Meanwhile I send original patchset with addressed remaining comments.

To: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
To: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
To: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
To: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
To: David Airlie <airlied@xxxxxxxxx>
To: Daniel Vetter <daniel@xxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx
Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
Signed-off-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>

---
Changes in v4:
- split "Separate wakeref tracking" to smaller parts
- fixed typos,
- Link to v1-v3: https://patchwork.freedesktop.org/series/100327/

---
Andrzej Hajda (7):
       lib/ref_tracker: add unlocked leak print helper
       lib/ref_tracker: __ref_tracker_dir_print improve printing
       lib/ref_tracker: add printing to memory buffer
       lib/ref_tracker: remove warnings in case of allocation failure
       drm/i915: Separate wakeref tracking types from rpm
       drm/i915: Correct type of wakeref variable
       drm/i915: replace Intel internal tracker with kernel core ref_tracker

Chris Wilson (3):
       drm/i915: Separate wakeref tracking
       drm/i915: Track leaked gt->wakerefs
       drm/i915/gt: Hold a wakeref for the active VM

  drivers/gpu/drm/i915/Kconfig.debug                 |  19 ++
  drivers/gpu/drm/i915/Makefile                      |   1 +
  drivers/gpu/drm/i915/display/intel_display_power.c |   2 +-
  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c     |   7 +-
  .../drm/i915/gem/selftests/i915_gem_coherency.c    |  10 +-
  drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c |  14 +-
  drivers/gpu/drm/i915/gt/intel_breadcrumbs.c        |  13 +-
  drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h  |   3 +-
  drivers/gpu/drm/i915/gt/intel_context.h            |  15 +-
  drivers/gpu/drm/i915/gt/intel_context_types.h      |   2 +
  drivers/gpu/drm/i915/gt/intel_engine_pm.c          |  10 +-
  drivers/gpu/drm/i915/gt/intel_engine_types.h       |   2 +
  .../gpu/drm/i915/gt/intel_execlists_submission.c   |   2 +-
  drivers/gpu/drm/i915/gt/intel_gt_pm.c              |  12 +-
  drivers/gpu/drm/i915/gt/intel_gt_pm.h              |  38 +++-
  drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c      |   4 +-
  drivers/gpu/drm/i915/gt/selftest_engine_cs.c       |  20 +-
  drivers/gpu/drm/i915/gt/selftest_gt_pm.c           |   5 +-
  drivers/gpu/drm/i915/gt/selftest_reset.c           |  10 +-
  drivers/gpu/drm/i915/gt/selftest_rps.c             |  17 +-
  drivers/gpu/drm/i915/gt/selftest_slpc.c            |   5 +-
  drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c  |  11 +-
  drivers/gpu/drm/i915/i915_driver.c                 |   2 +-
  drivers/gpu/drm/i915/i915_pmu.c                    |  16 +-
  drivers/gpu/drm/i915/intel_runtime_pm.c            | 221 ++-------------------
  drivers/gpu/drm/i915/intel_runtime_pm.h            |  11 +-
  drivers/gpu/drm/i915/intel_wakeref.c               |   7 +-
  drivers/gpu/drm/i915/intel_wakeref.h               | 112 ++++++++++-
  include/linux/ref_tracker.h                        |  31 ++-
  lib/ref_tracker.c                                  | 179 ++++++++++++++---
  30 files changed, 469 insertions(+), 332 deletions(-)
---
base-commit: 1ddc2effff762c6a109af52f3c39534c7115aebe
change-id: 20230224-track_gt-1b3da8bdacd7

Best regards,




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux