As you have checked my comments against documentation you have for older platforms (obviously better than what I have): for the whole set: Reviewed-by: Jouni Högander <jouni.hogander@xxxxxxxxx> BR, Jouni Högander On Tue, 2023-03-14 at 15:02 +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Do a bit of cleanup/reorganization around mostly plane > relatd stuff, and also add some more plane/pipe registers > that are useful for development/debugging. > > Ville Syrjälä (9): > drm/i915: Stop using pipe_offsets[] for PIPE_MISC* > drm/i915: s/PIPEMISC/PIPE_MISC/ > drm/i915: Define more pipe timestamp registers > drm/i915: Program VLV/CHV PIPE_MSA_MISC register > drm/i915: Define skl+ universal plane SURFLIVE registers > drm/i915: Define vlv/chv sprite plane SURFLIVE registers > drm/i915: Clean up skl+ plane alpha bits > drm/i915: Relocate intel_plane_check_src_coordinates() > drm/i915: Extract intel_sprite_uapi.c > > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- > .../gpu/drm/i915/display/intel_atomic_plane.c | 60 +++++- > .../gpu/drm/i915/display/intel_atomic_plane.h | 1 + > drivers/gpu/drm/i915/display/intel_cursor.c | 1 - > drivers/gpu/drm/i915/display/intel_ddi.c | 1 - > drivers/gpu/drm/i915/display/intel_display.c | 59 +++--- > drivers/gpu/drm/i915/display/intel_display.h | 2 +- > drivers/gpu/drm/i915/display/intel_sprite.c | 183 ---------------- > -- > .../gpu/drm/i915/display/intel_sprite_uapi.c | 127 ++++++++++++ > .../gpu/drm/i915/display/intel_sprite_uapi.h | 15 ++ > .../drm/i915/display/skl_universal_plane.c | 1 - > drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- > drivers/gpu/drm/i915/i915_reg.h | 77 ++++++-- > drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 6 +- > 15 files changed, 295 insertions(+), 243 deletions(-) > create mode 100644 drivers/gpu/drm/i915/display/intel_sprite_uapi.c > create mode 100644 drivers/gpu/drm/i915/display/intel_sprite_uapi.h >