Thank you for the Review. Pushed. -Radhakrishna Sripada > -----Original Message----- > From: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> > Sent: Thursday, March 9, 2023 9:18 AM > To: Sripada, Radhakrishna <radhakrishna.sripada@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Auld, Matthew <matthew.auld@xxxxxxxxx>; > Wilson, Chris P <chris.p.wilson@xxxxxxxxx> > Subject: Re: [PATCH v3 4/5] drm/i915/fbdev: lock the fbdev obj > before vma pin > > Hi Radhakrishna, > > On Wed, Mar 01, 2023 at 12:10:52PM -0800, Radhakrishna Sripada wrote: > > From: Tejas Upadhyay <tejas.upadhyay@xxxxxxxxx> > > > > lock the fbdev obj before calling into > > i915_vma_pin_iomap(). This helps to solve below : > > > > <7>[ 93.563308] i915 0000:00:02.0: [drm:intelfb_create [i915]] no BIOS fb, > allocating a new one > > <4>[ 93.581844] ------------[ cut here ]------------ > > <4>[ 93.581855] WARNING: CPU: 12 PID: 625 at > drivers/gpu/drm/i915/gem/i915_gem_pages.c:424 > i915_gem_object_pin_map+0x152/0x1c0 [i915] > > > > Fixes: f0b6b01b3efe ("drm/i915: Add ww context to intel_dpt_pin, v2.") > > Cc: Chris Wilson <chris.p.wilson@xxxxxxxxx> > > Cc: Matthew Auld <matthew.auld@xxxxxxxxx> > > Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > > Signed-off-by: Tejas Upadhyay <tejas.upadhyay@xxxxxxxxx> > > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx> > > Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> > > Andi