On Tue, Mar 07, 2023 at 12:12:46PM -0800, Matt Roper wrote:
> On Tue, Mar 07, 2023 at 12:22:38AM -0300, Gustavo Sousa wrote:
> > Wa_1606376872 applies to all Xe_LP IPs.
>
> "...except DG1"
Oh, okay. I thought there was distinction between Xe_LP and Xe_LP+.
>
> Aside from that,
>
> Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
Thanks for the review, Matt! Should I send a v2 or can the amend suggested above
be done while applying?
--
Gustavo Sousa
>
> >
> > Signed-off-by: Gustavo Sousa <gustavo.sousa@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++
> > drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +++++-
> > 2 files changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> > index 08d76aa06974..4aecb5a7b631 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> > @@ -478,6 +478,9 @@
> > #define HDC_FORCE_NON_COHERENT (1 << 4)
> > #define HDC_BARRIER_PERFORMANCE_DISABLE (1 << 10)
> >
> > +#define COMMON_SLICE_CHICKEN4 _MMIO(0x7300)
> > +#define DISABLE_TDC_LOAD_BALANCING_CALC REG_BIT(6)
> > +
> > #define GEN8_HDC_CHICKEN1 _MMIO(0x7304)
> >
> > #define GEN11_COMMON_SLICE_CHICKEN3 _MMIO(0x7304)
> > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > index 32aa1647721a..8092f289c492 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> > @@ -743,9 +743,13 @@ static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
> > FF_MODE2_GS_TIMER_224,
> > 0, false);
> >
> > - if (!IS_DG1(i915))
> > + if (!IS_DG1(i915)) {
> > /* Wa_1806527549 */
> > wa_masked_en(wal, HIZ_CHICKEN, HZ_DEPTH_TEST_LE_GE_OPT_DISABLE);
> > +
> > + /* Wa_1606376872 */
> > + wa_masked_en(wal, COMMON_SLICE_CHICKEN4, DISABLE_TDC_LOAD_BALANCING_CALC);
> > + }
> > }
> >
> > static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
> > --
> > 2.39.2
> >
>
> --
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation
