> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Thomas > Zimmermann > Sent: tiistai 28. helmikuuta 2023 17.46 > To: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>; > maarten.lankhorst@xxxxxxxxxxxxxxx; airlied@xxxxxxxxx; daniel@xxxxxxxx; Nikula, > Jani <jani.nikula@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] Revert "drm/shmem-helper: Switch to > reservation lock" > > Hi > > Am 28.02.23 um 16:28 schrieb Dmitry Osipenko: > > On 2/28/23 18:26, Thomas Zimmermann wrote: > >> This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. > >> > >> The locking appears incomplete. A caller of SHMEM helper's pin > >> function never acquires the dma-buf reservation lock. So we get > >> > >> WARNING: CPU: 3 PID: 967 at > >> drivers/gpu/drm/drm_gem_shmem_helper.c:243 > >> drm_gem_shmem_pin+0x42/0x90 [drm_shmem_helper] > >> > >> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > >> --- > > > > Thanks Thomas, > > > > Acked-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> > > > > Thanks, merged now. I hope this fixes the immediate issues. According to pre-merge results: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114478v1/index.html? So should fix. > > Best regards > Thomas > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Ivo Totev
