On Thu, 23 Feb 2023, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Thu, Feb 23, 2023 at 05:01:11PM +0000, Shankar, Uma wrote: >> >> >> > -----Original Message----- >> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >> > Sent: Thursday, February 23, 2023 8:37 PM >> > To: Shankar, Uma <uma.shankar@xxxxxxxxx> >> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> > Subject: Re: [PATCH 1/2] drm/i915: Fix audio ELD handling for DP MST >> > >> > On Wed, Feb 22, 2023 at 05:59:45PM +0000, Shankar, Uma wrote: >> > > >> > > >> > > > -----Original Message----- >> > > > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf >> > > > Of Ville Syrjala >> > > > Sent: Monday, February 20, 2023 8:48 PM >> > > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> > > > Subject: [PATCH 1/2] drm/i915: Fix audio ELD handling >> > > > for DP MST >> > > >> > > Nit: May be append "display" to drm/i915. >> > >> > Don't think I've ever used that one. Seems a bit too generic to provide any real >> > additional information to the table that wouldn't usually be obvious from the subject >> > anyway. >> > Do other people find /display useful? >> > >> > I guess I could have used a more specific /mst in this case, but then again I already >> > mention MST in the subject anyway so seems a bit redundant. >> >> I think there are mixed declarations in our tree, no clear rule as such. >> Will leave it you, maybe a general guideline would be good to make it >> all consistent. > > Yeah, some general guidelines might be good to figure out. > > In the meantime I've pushed these patches as is for now. > Thanks for the review. Personally I only ever use drm/i915/display when it's really about *everything* related to display, the highest level display stuff. Never for details like this. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
