Re: [PATCH 5/9] drm/i915/perf: Group engines into respective OA groups

["Dixit, Ashutosh" <ashutosh.dixit@xxxxxxxxx>]

On Thu, 16 Feb 2023 02:51:34 -0800, Jani Nikula wrote:
>
> > +static int oa_init_gt(struct intel_gt *gt)
> > +{
> > +	u32 num_groups = __num_perf_groups_per_gt(gt);
> > +	struct intel_engine_cs *engine;
> > +	struct i915_perf_group *g;
> > +	intel_engine_mask_t tmp;
> > +
> > +	g = kcalloc(num_groups, sizeof(*g), GFP_KERNEL);
> > +	if (drm_WARN_ON(&gt->i915->drm, !g))
> > +		return -ENOMEM;
>
> No warnings or messages on -ENOMEM is standard policy.

Hmm I think this is the only error for which this code is failing the
probe. So if we are not going to fail the probe, we should at least allow a
WARN_ON? Exception proves the rule?