On Wed, Feb 15, 2023 at 01:21:39PM +0200, Jani Nikula wrote: > On Mon, 13 Feb 2023, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > On Mon, Feb 13, 2023 at 10:00:00PM +0200, Jani Nikula wrote: > >> Move the generic sanitize_watermarks() to intel_wm.[ch] and rename as > > > > It's not generic though. Only the ilk_ stuff uses it. > > Okay, so the caller side requires HAS_GMCH() and the callee side > requires .optimize_watermarks != NULL. That indeed leaves us with PCH > split platforms before display version 9. > > However, the implementation of sanitize_watermarks() seems pretty > generic, right? > > I guess the question is, do you suggest moving the whole thing to > i9xx_wm.c and specifically not calling it on display 9+, or do you just > want the commit message to reflect the above? What I actually want is to just get rid of it entirely. But that would require doing some work on the ilk wm code. So in the meantime I suppse I'd prefer to hide it away next to all the other ilk wm code so that no one gets any more confusedby it. -- Ville Syrjälä Intel
