On Mon, 13 Feb 2023, "Das, Nirmoy" <nirmoy.das@xxxxxxxxxxxxxxx> wrote: > On 2/10/2023 4:03 PM, Andi Shyti wrote: >> It is becoming a strong habit to call the drm_i915_private >> structures "i915", but there are still many left that are called >> dev_priv. >> >> Sometimes this makes grepping a bit challenging and anyway it >> keeps a coherent style. >> >> Rename all the "dev_priv" structures in the gt/* directory to >> "i915". >> >> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> >> --- >> Hi, >> >> just checking if we want something similar. I have this same >> replicated patch for the rest of i915 but I want to make sure we >> actually want it. > > I might be lacking historical context here but I assumption is we are > moving towards replacing dev_priv with i915 everywhere. Yes. The implicit dev_priv still present in some of the register macros is the only reason not to convert, and even in those cases we should look into fixing that too. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
