On 08/02/2023 12:31, Kamil Konieczny wrote:
Hi Tvrtko,
one small nit, see below.
On 2023-02-03 at 11:16:34 +0000, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
If output is redirected to a file, or a pipe, lets not repeat the headers
because that can usually mean user is trying to parse the data later and
so repeated headers are a hindrance.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: Caleb Callaway <caleb.callaway@xxxxxxxxx>
---
tools/intel_gpu_top.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 0a1de41b3374..e2a7f4753099 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1391,6 +1391,7 @@ static unsigned int stdout_level;
#define STDOUT_HEADER_REPEAT 20
static unsigned int stdout_lines = STDOUT_HEADER_REPEAT;
+static bool stdout_header_repeat;
static void
stdout_open_struct(const char *name)
@@ -1580,16 +1581,22 @@ static const struct print_operations term_pops = {
static bool print_groups(struct cnt_group **groups)
{
- unsigned int headers = stdout_lines % STDOUT_HEADER_REPEAT + 1;
+ static bool headers_printed = false;
----------------------------------- ^
Remove this initialization (use checkpatch from Linux kernel).
Please correct and resend (you can keep my r-b).
Fixed and pushed, thanks for the review!
Regards,
Tvrtko
