On Wed, Aug 14, 2013 at 11:38:36AM +0200, Daniel Vetter wrote: > From: Ben Widawsky <ben@xxxxxxxxxxxx> > > + vma = i915_gem_obj_lookup_or_create_vma(obj, vm); > + if (IS_ERR(vma)) { > + /* XXX: We don't need an error path fro vma because if > + * the vma was created just for this execbuf, object > + * unreference should kill it off.*/ The XXX part here is that before the object is finally unreffed we have a dangling vma and so we need to take care else way not to assume that a vma is implicitly bound. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx