Re: [PATCH 4/4] drm/i915/pxp: fix __le64 access to get rid of sparse warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> __le64 and friends should go through the cpu_to_* and *_to_cpu
> accessors:
> 
> drivers/gpu/drm/i915/pxp/intel_pxp_huc.c:41:35: warning: incorrect type in
> assignment (different base types)
> drivers/gpu/drm/i915/pxp/intel_pxp_huc.c:41:35:    expected restricted
> __le64 [assigned] [usertype] huc_base_address
> drivers/gpu/drm/i915/pxp/intel_pxp_huc.c:41:35:    got unsigned long long
> [assigned] [usertype] huc_phys_addr
> 
> Cc: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> Cc: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
Reviewed-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/pxp/intel_pxp_huc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_huc.c
> b/drivers/gpu/drm/i915/pxp/intel_pxp_huc.c
> index 64609d1b1c0f..23431c36b60b 100644
> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_huc.c
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_huc.c
> @@ -38,7 +38,7 @@ int intel_pxp_huc_load_and_auth(struct intel_pxp
> *pxp)
>  	huc_in.header.command_id  = PXP43_CMDID_START_HUC_AUTH;
>  	huc_in.header.status      = 0;
>  	huc_in.header.buffer_len  = sizeof(huc_in.huc_base_address);
> -	huc_in.huc_base_address   = huc_phys_addr;
> +	huc_in.huc_base_address   = cpu_to_le64(huc_phys_addr);
> 
>  	err = intel_pxp_tee_stream_message(pxp, client_id, fence_id,
>  					   &huc_in, sizeof(huc_in),
> --
> 2.34.1





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux