> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Sent: Thursday, February 2, 2023 2:54 PM > To: Murthy, Arun R <arun.r.murthy@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Syrjala, Ville <ville.syrjala@xxxxxxxxx> > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear > buffers > > On Thu, Feb 02, 2023 at 06:51:49AM +0000, Murthy, Arun R wrote: > > Gentle Reminder! > > The patch is pending since a long time. > > Please review the igt changes here: > https://patchwork.freedesktop.org/series/113525/ > then we can actually test this (and any other new modifier in the future). > Done! This patch is to add support for linear buffer in the driver and shouldn't conflict with the IGT patch series https://patchwork.freedesktop.org/series/113525/ Thanks and Regards, Arun R Murthy -------------------- > > > > Thanks and Regards, > > Arun R Murthy > > ------------------- > > > > > -----Original Message----- > > > From: Murthy, Arun R > > > Sent: Monday, January 23, 2023 12:14 PM > > > To: 'Ville Syrjälä' <ville.syrjala@xxxxxxxxxxxxxxx> > > > Cc: 'intel-gfx@xxxxxxxxxxxxxxxxxxxxx' > > > <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>; > > > Syrjala, Ville <ville.syrjala@xxxxxxxxx> > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > Linear buffers > > > > > > Any review comments on this. Gentle Reminder! > > > > > > Thanks and Regards, > > > Arun R Murthy > > > -------------------- > > > > > > > -----Original Message----- > > > > From: Murthy, Arun R > > > > Sent: Tuesday, January 17, 2023 2:09 PM > > > > To: 'Ville Syrjälä' <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Cc: 'intel-gfx@xxxxxxxxxxxxxxxxxxxxx' > > > > <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>; > > > > Syrjala, Ville <ville.syrjala@xxxxxxxxx> > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > Linear buffers > > > > > > > > Gentle Reminder! > > > > > > > > Thanks and Regards, > > > > Arun R Murthy > > > > ------------------- > > > > > > > > > -----Original Message----- > > > > > From: Murthy, Arun R > > > > > Sent: Friday, January 13, 2023 12:57 PM > > > > > To: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Syrjala, Ville > > > > > <ville.syrjala@xxxxxxxxx> > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip > > > > > on Linear buffers > > > > > > > > > > > On Fri, Oct 28, 2022 at 03:23:02AM +0000, Murthy, Arun R wrote: > > > > > > > Gentle Reminder! > > > > > > > > > > > > Is the igt stuff merged, and did this pass the test? > > > > > > > > > > > With IGT alone the tests will fail without the kernel patch. > > > > > The > > > > > tests(https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_112722v2/s > > > > > hard > > > > > s- > > > > > all.html?testfilter=kms_async_flips) are passing with IGT and > > > > > kernel > > > patch. > > > > > > > > > > Thanks and Regards, > > > > > Arun R Murthy > > > > > -------------------- > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Murthy, Arun R > > > > > > > > Sent: Monday, October 10, 2022 1:24 PM > > > > > > > > To: 'intel-gfx@xxxxxxxxxxxxxxxxxxxxx' > > > > > > > > <intel-gfx@xxxxxxxxxxxxxxxxxxxxx> > > > > > > > > Cc: Syrjala, Ville <ville.syrjala@xxxxxxxxx> > > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > > Linear buffers > > > > > > > > > > > > > > > > Ville, > > > > > > > > Gentle reminder! > > > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > > Arun R Murthy > > > > > > > > -------------------- > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Murthy, Arun R > > > > > > > > > Sent: Monday, September 19, 2022 10:38 AM > > > > > > > > > To: 'intel-gfx@xxxxxxxxxxxxxxxxxxxxx' > > > > > > > > > <intel-gfx@xxxxxxxxxxxxxxxxxxxxx> > > > > > > > > > Cc: Syrjala, Ville <ville.syrjala@xxxxxxxxx> > > > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > > > Linear buffers > > > > > > > > > > > > > > > > > > If no comments, can anyone merge the patch! > > > > > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > > > Arun R Murthy > > > > > > > > > -------------------- > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > > From: Murthy, Arun R > > > > > > > > > > Sent: Wednesday, September 14, 2022 4:21 PM > > > > > > > > > > To: Murthy, Arun R <arun.r.murthy@xxxxxxxxx>; intel- > > > > > > > > > > gfx@xxxxxxxxxxxxxxxxxxxxx > > > > > > > > > > Cc: Syrjala, Ville <ville.syrjala@xxxxxxxxx> > > > > > > > > > > Subject: RE: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > > > > Linear buffers > > > > > > > > > > > > > > > > > > > > Gentle Reminder! > > > > > > > > > > Any comments? > > > > > > > > > > > > > > > > > > > > Thanks and Regards, > > > > > > > > > > Arun R Murthy > > > > > > > > > > -------------------- > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > > > From: Intel-gfx > > > > > > > > > > > <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> > > > > > > > > > > > On Behalf Of Murthy, Arun R > > > > > > > > > > > Sent: Friday, September 9, 2022 9:17 AM > > > > > > > > > > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > > > > > > > > > > Cc: Syrjala, Ville <ville.syrjala@xxxxxxxxx> > > > > > > > > > > > Subject: Re: [PATCHv3] drm/i915: Support > > > > > > > > > > > Async Flip on Linear buffers > > > > > > > > > > > > > > > > > > > > > > Gentle Reminder! > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > > > > From: Murthy, Arun R <arun.r.murthy@xxxxxxxxx> > > > > > > > > > > > > Sent: Tuesday, September 6, 2022 9:18 AM > > > > > > > > > > > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > > > > > > > > > > > Cc: ville.syrjala@xxxxxxxxxxxxxxx; Murthy, Arun R > > > > > > > > > > > > <arun.r.murthy@xxxxxxxxx> > > > > > > > > > > > > Subject: [PATCHv3] drm/i915: Support Async Flip on > > > > > > > > > > > > Linear buffers > > > > > > > > > > > > > > > > > > > > > > > > Starting from Gen12 Async Flip is supported on linear > buffers. > > > > > > > > > > > > This patch enables support for async on linear buffer. > > > > > > > > > > > > > > > > > > > > > > > > UseCase: In Hybrid graphics, for hardware > > > > > > > > > > > > unsupported pixel formats it will be converted to > > > > > > > > > > > > linear memory and then > > > > > composed. > > > > > > > > > > > > > > > > > > > > > > > > v2: Added use case > > > > > > > > > > > > v3: Added FIXME for ICL indicating the > > > > > > > > > > > > restrictions > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Arun R Murthy > > > > > > > > > > > > <arun.r.murthy@xxxxxxxxx> > > > > > > > > > > > > --- > > > > > > > > > > > > drivers/gpu/drm/i915/display/intel_display.c | 14 > > > > > > > > > > > > ++++++++++++++ > > > > > > > > > > > > 1 file changed, 14 insertions(+) > > > > > > > > > > > > > > > > > > > > > > > > diff --git > > > > > > > > > > > > a/drivers/gpu/drm/i915/display/intel_display.c > > > > > > > > > > > > b/drivers/gpu/drm/i915/display/intel_display.c > > > > > > > > > > > > index be7cff722196..1880cfe70a7d 100644 > > > > > > > > > > > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > > > > > > > > > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > > > > > > > > > > > @@ -6610,6 +6610,20 @@ static int > > > > > > > > > > > > intel_async_flip_check_hw(struct > > > > > > > > > > > > intel_atomic_state *state, struct > > > > > > in > > > > > > > > > > > > * this selectively if required. > > > > > > > > > > > > */ > > > > > > > > > > > > switch (new_plane_state->hw.fb->modifier) { > > > > > > > > > > > > + case DRM_FORMAT_MOD_LINEAR: > > > > > > > > > > > > + /* > > > > > > > > > > > > + * FIXME: Async on Linear buffer is > > > supported > > > > > > > > on ICL > > > > > > > > > > > > as > > > > > > > > > > > > + * but with additional alignment and > > > fbc > > > > > > > > restrictions > > > > > > > > > > > > + * need to be taken care of. These > > > aren't > > > > > > > > applicable > > > > > > > > > > > > for > > > > > > > > > > > > + * gen12+. > > > > > > > > > > > > + */ > > > > > > > > > > > > + if (DISPLAY_VER(i915) < 12) { > > > > > > > > > > > > + drm_dbg_kms(&i915->drm, > > > > > > > > > > > > + "[PLANE:%d:%s] > > > Modifier > > > > > > > > does not > > > > > > > > > > > > support async flips\n", > > > > > > > > > > > > + plane->base.base.id, > > > plane- > > > > > > > > > > > > >base.name); > > > > > > > > > > > > + return -EINVAL; > > > > > > > > > > > > + } > > > > > > > > > > > > + > > > > > > > > > > > > case I915_FORMAT_MOD_X_TILED: > > > > > > > > > > > > case I915_FORMAT_MOD_Y_TILED: > > > > > > > > > > > > case I915_FORMAT_MOD_Yf_TILED: > > > > > > > > > > > > -- > > > > > > > > > > > > 2.25.1 > > > > > > > > > > > > -- > > > > > > Ville Syrjälä > > > > > > Intel > > -- > Ville Syrjälä > Intel
