From: John Harrison <John.C.Harrison@xxxxxxxxx>
It is technically possible to get a hung context without a valid
request. In such a situation, try to provide as much information in
the error capture as possible rather than just aborting and capturing
nothing.
Similarly, in the case of an engine reset failure the GuC is not able
to report the guilty context. So try a manual search instead of
reporting nothing.
While doing all this, it was noticed that the locking was broken in a
number of places when searching for hung requests and dumping request
info. So fix all that up as well.
v2: Tidy up code flow in error capture. Reword some comments/messages.
(review feedback from Tvrtko)
Also fix up request locking issues from earlier changes noticed during
code review of this change.
v3: Fix some potential null pointer derefs and a reference leak.
Add new patch to refactor the duplicated hung request search code into
a common backend agnostic wrapper function and use the correct
spinlocks for the correct lists. Also tweak some of the patch
descriptions for better accuracy.
v4: Shuffle some code around to more appropriate source files. Fix
potential leak of GuC capture object after code flow re-org and pull
improved info message earlier (Daniele). Also rename the GuC capture
object to be more consistent.
v5: Split one self contained locking fix out into a separate patch
and rename a function to be shorter (Tvrtko).
v6: s/locking/reference counting/ in message of patch #2 (Tvrtko)
Signed-off-by: John Harrison <John.C.Harrison@xxxxxxxxx>
John Harrison (8):
drm/i915/guc: Fix locking when searching for a hung request
drm/i915: Fix request ref counting during error capture & debugfs dump
drm/i915: Fix up locking around dumping requests lists
drm/i915: Allow error capture without a request
drm/i915: Allow error capture of a pending request
drm/i915/guc: Look for a guilty context when an engine reset fails
drm/i915/guc: Add a debug print on GuC triggered reset
drm/i915/guc: Rename GuC register state capture node to be more
obvious
drivers/gpu/drm/i915/gt/intel_context.c | 4 +-
drivers/gpu/drm/i915/gt/intel_context.h | 3 +-
drivers/gpu/drm/i915/gt/intel_engine.h | 4 +-
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 74 ++++++++-------
.../drm/i915/gt/intel_execlists_submission.c | 27 ++++++
.../drm/i915/gt/intel_execlists_submission.h | 4 +
.../gpu/drm/i915/gt/uc/intel_guc_capture.c | 8 +-
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 35 ++++++-
drivers/gpu/drm/i915/i915_gpu_error.c | 92 ++++++++++---------
drivers/gpu/drm/i915/i915_gpu_error.h | 2 +-
10 files changed, 160 insertions(+), 93 deletions(-)
--
2.39.1
