On Tue, 2023-01-24 at 13:43 -0500, Vivi, Rodrigo wrote: > On Tue, Jan 24, 2023 at 10:08:52AM -0800, Juston Li wrote: > > On Tue, 2023-01-24 at 10:17 -0500, Rodrigo Vivi wrote: > > > On Mon, Jan 23, 2023 at 09:31:49PM -0800, Alan Previn wrote: > > > > A driver bug was recently discovered where the security firmware > > > > was > > > > receiving internal HW signals indicating that session key > > > > expirations > > > > had occurred. Architecturally, the firmware was expecting a > > > > response > > > > from the GuC to acknowledge the event with the firmware side. > > > > However the OS was in a suspended state and GuC had been reset. > > > > > > > > Internal specifications actually required the driver to ensure > > > > that all active sessions be properly cleaned up in such cases where > > > > the system is suspended and the GuC potentially unable to respond. > > > > > > > > This patch adds the global teardown code in i915's suspend_prepare > > > > code path. > > > > > > > > Signed-off-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx> > > > > Reviewed-by: Juston Li <justonli@xxxxxxxxxxxx> > > > > > > it should probably contain some revision history above so the > > > reviewer can know what changed from the time he reviewed and now. > > > > > > it looks we have another function that I don't remember... > > > Juston, could you please confirm your review stands in this version? > > > if so feel free to add my ack with that. > > > > Sure, v6 is: > > Reviewed-by: Juston Li <justonli@xxxxxxxxxxxx> > > > Acked-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > > Thanks guys - will respin the final one (i hope) with tweaks on patch #2. ...alan
