On 20/01/2023 17:54, Sean Paul wrote:
On Thu, Jan 19, 2023 at 11:35:32AM +0100, Krzysztof Kozlowski wrote:
On 18/01/2023 20:30, Mark Yacoub wrote:
From: Sean Paul <seanpaul@xxxxxxxxxxxx>
This patch adds the register ranges required for HDCP key injection and
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
This applies to all your patches. Fix it everywhere.
My goodness, this is peak bikeshedding. Surely we have better things to do with
our time?
While I would not enforce this rule if there were no other issues with
the commits, Mark will have to cleanup/rework commits anyway, see other
review comments. Thus removing/slightly rephrasing a commit message
sounds like a minor issue to me.
Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
Signed-off-by: Mark Yacoub <markyacoub@xxxxxxxxxxxx>
Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-sean@xxxxxxxxxx #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-14-sean@xxxxxxxxxx #v2
Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-14-sean@xxxxxxxxxx #v3
Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-14-sean@xxxxxxxxxx #v4
Link: https://patchwork.freedesktop.org/patch/msgid/20220411204741.1074308-10-sean@xxxxxxxxxx #v5
Drop the links.
Why? I've always done this, it seems helpful to me?
I'd say, if you wish to include them, they belong to the cover letter,
not to the per-commit message. Once landed, they will serve no purpose.
--
With best wishes
Dmitry
