On Fri, 2023-01-20 at 08:27 +0000, Gupta, Anshuman wrote: > > > > -----Original Message----- > > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alan > > Previn > > Sent: Friday, January 20, 2023 1:20 AM > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: Vivi@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Teres Alexis, > > Alan Previn <alan.previn.teres.alexis@xxxxxxxxx>; Vivi, Rodrigo > > <rodrigo.vivi@xxxxxxxxx> > > Subject: [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion > > > > alan:snip.. > > + /* Completion Step 1 - poll for 'CNTL-BIT31 = 0' wait for hw teardown > > to complete */ > > + ret = intel_wait_for_register_fw(uncore, GU_CNTL, > > + DRIVERFLR_STATUS, 0, > > + flr_timeout_ms); > We need an error here if above wait timeout then below wait is essentially a NOP. > And driver may return before completion of FLR. > Thanks, > Anshuman Gupta. alan: my bad - good catch - will fix. alan:snip..
