On Wed, Jan 18, 2023 at 03:15:35PM +0200, Jani Nikula wrote:
> There's not that much organization with where the various HAS_FEATURE()
> macros are placed, but at least try to group them closer together.
yeap
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ad0c5fd0cc92..73ce5447cae8 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -187,8 +187,6 @@ struct i915_gem_mm {
> u32 shrink_count;
> };
>
> -#define HAS_HW_SAGV_WM(i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915))
> -
> struct i915_virtual_gpu {
> struct mutex lock; /* serialises sending of g2v_notify command pkts */
> bool active;
> @@ -444,9 +442,6 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)
>
> #define INTEL_REVID(dev_priv) (to_pci_dev((dev_priv)->drm.dev)->revision)
>
> -#define HAS_DSB(dev_priv) (INTEL_INFO(dev_priv)->display.has_dsb)
> -#define HAS_DSC(__i915) (RUNTIME_INFO(__i915)->has_dsc)
> -
> #define INTEL_DISPLAY_STEP(__i915) (RUNTIME_INFO(__i915)->step.display_step)
> #define INTEL_GRAPHICS_STEP(__i915) (RUNTIME_INFO(__i915)->step.graphics_step)
> #define INTEL_MEDIA_STEP(__i915) (RUNTIME_INFO(__i915)->step.media_step)
> @@ -858,6 +853,9 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
> #define HAS_RPS(dev_priv) (INTEL_INFO(dev_priv)->has_rps)
>
> #define HAS_DMC(dev_priv) (RUNTIME_INFO(dev_priv)->has_dmc)
> +#define HAS_DSB(dev_priv) (INTEL_INFO(dev_priv)->display.has_dsb)
> +#define HAS_DSC(__i915) (RUNTIME_INFO(__i915)->has_dsc)
> +#define HAS_HW_SAGV_WM(i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915))
>
> #define HAS_HECI_PXP(dev_priv) \
> (INTEL_INFO(dev_priv)->has_heci_pxp)
> --
> 2.34.1
>
