On Wed, Jan 11, 2023 at 03:55:24PM -0800, Radhakrishna Sripada wrote:
> Clock gating hooks to be initialized for MTL are yet to be implemented.
> Use a nop till we identify relevant WA's here.
>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx>
I wonder if we should just drop the MISSING_CASE warning on the default
branch here. When that was first added (gen6 era), we pretty much
expected every platform to have some kind of clock gating programming,
but a lot has changed since then (GT clock gating stuff gets handled via
GT workarounds now instead of here, we're starting to have lots of
platforms without display and its related clock gating, etc.).
I guess setting noop here is good for now, and if our next platform also
winds up being a noop we can make a change at that time.
Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 73c88b1c9545..41046ceca9db 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4819,7 +4819,9 @@ CG_FUNCS(nop);
> */
> void intel_init_clock_gating_hooks(struct drm_i915_private *dev_priv)
> {
> - if (IS_PONTEVECCHIO(dev_priv))
> + if (IS_METEORLAKE(dev_priv))
> + dev_priv->clock_gating_funcs = &nop_clock_gating_funcs;
> + else if (IS_PONTEVECCHIO(dev_priv))
> dev_priv->clock_gating_funcs = &pvc_clock_gating_funcs;
> else if (IS_DG2(dev_priv))
> dev_priv->clock_gating_funcs = &dg2_clock_gating_funcs;
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
