On Tue, 17 Jan 2023, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Tue, Jan 17, 2023 at 02:33:05PM +0200, Jani Nikula wrote: >> Let's see if this sticks. >> >> Jani Nikula (4): >> drm/i915: add gmch substruct to struct drm_i915_private >> drm/i915/gmch: split out soc/intel_gmch >> drm/i915/gmch: mass rename dev_priv to i915 >> drm/i915/gmch: move VGA set state to GMCH code > > My main worry with this name would be confusion with HAS_GMCH(). I know. Give me a better name, and I'll go with it. I just couldn't think of anything more appropriate. I guess this somewhat goes back to the HAS_GMCH_DISPLAY -> HAS_GMCH rename. BR, Jani. > >> >> drivers/gpu/drm/i915/Makefile | 1 + >> drivers/gpu/drm/i915/display/intel_vga.c | 32 +--- >> drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 2 +- >> drivers/gpu/drm/i915/i915_driver.c | 145 +----------------- >> drivers/gpu/drm/i915/i915_drv.h | 10 +- >> drivers/gpu/drm/i915/soc/intel_gmch.c | 171 ++++++++++++++++++++++ >> drivers/gpu/drm/i915/soc/intel_gmch.h | 18 +++ >> 7 files changed, 204 insertions(+), 175 deletions(-) >> create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.c >> create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.h >> >> -- >> 2.34.1 -- Jani Nikula, Intel Open Source Graphics Center