== Series Details == Series: drm/i915: extract vblank/scanline code to a separate file (rev2) URL : https://patchwork.freedesktop.org/series/111854/ State : warning == Summary == Error: dim checkpatch failed f7f0f440ba53 drm/i915/irq: split out vblank/scanline code to intel_vblank.[ch] Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' Traceback (most recent call last): File "scripts/spdxcheck.py", line 6, in <module> from ply import lex, yacc ModuleNotFoundError: No module named 'ply' -:53: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 -:95: WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns #95: FILE: drivers/gpu/drm/i915/display/intel_vblank.c:38: + * -vbs-----> <---vbs+1---> <---vbs+2---> <-----0-----> <-----1-----> <-----2--- (scanline counter gen2) -:96: WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #96: FILE: drivers/gpu/drm/i915/display/intel_vblank.c:39: + * -vbs-2---> <---vbs-1---> <---vbs-----> <---vbs+1---> <---vbs+2---> <-----0--- (scanline counter gen3+) -:97: WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns #97: FILE: drivers/gpu/drm/i915/display/intel_vblank.c:40: + * -vbs-2---> <---vbs-2---> <---vbs-1---> <---vbs-----> <---vbs+1---> <---vbs+2- (scanline counter hsw+ hdmi) -:396: WARNING:LONG_LINE: line length of 116 exceeds 100 columns #396: FILE: drivers/gpu/drm/i915/display/intel_vblank.c:339: + position = (intel_de_read_fw(dev_priv, PIPEFRAMEPIXEL(pipe)) & PIPE_PIXEL_MASK) >> PIPE_PIXEL_SHIFT; -:460: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #460: FILE: drivers/gpu/drm/i915/display/intel_vblank.c:403: + return drm_crtc_vblank_helper_get_vblank_timestamp_internal( total: 0 errors, 5 warnings, 1 checks, 893 lines checked 3c80acd1a292 drm/i915/display: move more scanline functions to intel_vblank.[ch] -:87: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #87: FILE: drivers/gpu/drm/i915/display/intel_vblank.c:428: + msleep(5); total: 0 errors, 1 warnings, 0 checks, 93 lines checked 90576232dbdf drm/i915/display: use common function for checking scanline is moving 9da93ebd1e3d drm/i915/vblank: use intel_de_read() 7587efc4f41a drm/i915/vblank: add and use intel_de_read64_2x32() to read vblank counter