Re: [PATCH] drm/i915/display: Fix typo for reference clock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jani,

There are no bug reports for it. It was pointed out by Matt in another patch series.

https://patchwork.freedesktop.org/patch/517283/?series=111472&rev=3

Regards

Chaitanya

> -----Original Message-----
> From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Sent: Monday, January 16, 2023 2:42 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@xxxxxxxxx>; intel-
> gfx@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re:  [PATCH] drm/i915/display: Fix typo for reference clock
> 
> On Thu, 12 Jan 2023, Chaitanya Kumar Borah
> <chaitanya.kumar.borah@xxxxxxxxx> wrote:
> > Fix typo for reference clock from 24400 to 24000
> 
> Is there a bug report? What's the impact?
> 
> It's obvious and easy to say there's a typo, but the harder part is matching
> this against observed faulty behaviour, and that's something people will
> want to do to match bug reports and fixes.
> 
> BR,
> Jani.
> 
> >
> > Signed-off-by: Chaitanya Kumar Borah
> <chaitanya.kumar.borah@xxxxxxxxx>
> > ---
> >  drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > index 0c107a38f9d0..7e16b655c833 100644
> > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > @@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals
> adlp_cdclk_table[] = {
> >  	{ .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
> >  	{ .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
> >  	{ .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
> > -	{ .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
> > +	{ .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
> >
> >  	{ .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
> >  	{ .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
> 
> --
> Jani Nikula, Intel Open Source Graphics Center




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux