Re: [PATCH 21/29] drm/i915: mm_list is per VMA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 08, 2013 at 08:46:46AM +0200, Daniel Vetter wrote:
> On Thu, Aug 8, 2013 at 6:32 AM, Ben Widawsky <ben@xxxxxxxxxxxx> wrote:
> > You killed a BUG in i915_gem_retire_requests_ring, shouldn't that be a WARN or are you in the business of completely killing assertions now :p?
> 
> Yeah, and my little commit message annotation even explained that it's
> fully redundant since the move_to_inactive function called on the next
> line has the exact same check ;-)

Heh, I realized this as I was dozing off last night... "didn't danvet
point that out already." Oh well, at least I passed the test.

-- 
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux